WordPress.org

Ready to get started?Download WordPress

Forums

Easy Nivo Slider
WordPress 3.2+ breaks slider (13 posts)

  1. Yitzi
    Member
    Posted 3 years ago #

    Upgrading to WordPress 3.2 breaks the slider on my site. Getting a javascript error about "undefined" on line 20 col 355 which appears to playing with the title attribute on the img tag.

    Looking into "list-images-single-post.php" I found this line:

    // Create the image tag.  The title should be pulled from the post title
    			echo '<img src="'.$arr_image[0].'" '.
    				(('true' == $parms['caption']) ? ' title="'.get_the_title($id).'"' : '').
    				$thumbnail.'/>';

    No title attribute appears to be generated if captioning is off. I changed the line to:

    // Create the image tag.  The title should be pulled from the post title
    			echo '<img src="'.$arr_image[0].'" '.
    				(('true' == $parms['caption']) ? ' title="'.get_the_title($id).'"' : ' title=""').
    				$thumbnail.'/>';

    to just generate an empty attribute when captioning is off. Works for me and captions still do not show if you don't want them.

    Line would have to be fixed in all the "list-images-*.php" files.

  2. tomwgf
    Member
    Posted 3 years ago #

    hi
    i have a similar problem since upgrading to WP 3.2.1. i was on 1.6.1 of easy nivo but have now updated to the 2.0 beta but it still does not work.

    the javascript error i get is this:

    --------------------------^
    [25/07/11 09:19:29] JavaScript - http://website.co.uk/
    Event thread: DOMContentLoaded
    Uncaught exception: TypeError: Cannot convert 'title' to object
    Error thrown at line 20, column 565 in <anonymous function>(settings) in http://website.co.uk/wp-content/plugins/easy-nivo-slider-2.0/3rd-party/jquery.nivo.slider.pack.js?ver=2.5.1:
        if(title.substr(0,1)=='#')
    called from line 22, column 0 in <anonymous function>(element, options) in http://website.co.uk/wp-content/plugins/easy-nivo-slider-2.0/3rd-party/jquery.nivo.slider.pack.js?ver=2.5.1:
        processCaption(settings);
    called from line 67, column 294 in <anonymous function: $.fn.nivoSlider>(key, value) in http://website.co.uk/wp-content/plugins/easy-nivo-slider-2.0/3rd-party/jquery.nivo.slider.pack.js?ver=2.5.1:
        var nivoslider=new NivoSlider(this,options);
    called from line 16, column 24139 in <anonymous function: each>(a, c, d) in http://website.co.uk/wp-includes/js/jquery/jquery.js?ver=1.6.1:
        if(c.call(a[g],g,a[g++])===!1)
    called via Function.prototype.call() from line 16, column 17720 in <anonymous function: each>(a, b) in http://website.co.uk/wp-includes/js/jquery/jquery.js?ver=1.6.1:
        return e.each(this,a,b)
    called from line 67, column 138 in <anonymous function: $.fn.nivoSlider>(options) in http://website.co.uk/wp-content/plugins/easy-nivo-slider-2.0/3rd-party/jquery.nivo.slider.pack.js?ver=2.5.1:
        return this.each(function(key,value){var element=$(this);if(element.data('nivoslider'))return element.data('nivoslider');var nivoslider=new NivoSlider(this,options);element.data('nivoslider',nivoslider);});
    called from line 3, column 3 in <anonymous function>($) in http://website.co.uk/:
        $("#slider-1").nivoSlider({
    called from line 16, column 30126 in <anonymous function: resolveWith>(e, f) in http://website.co.uk/wp-includes/js/jquery/jquery.js?ver=1.6.1:
        a.shift().apply(e,f)
    called via Function.prototype.apply() from line 16, column 20176 in <anonymous function: ready>(a) in http://website.co.uk/wp-includes/js/jquery/jquery.js?ver=1.6.1:
        y.resolveWith(c,[e]),e.fn.trigger&&e(c).trigger("ready").unbind("ready")
    called from line 16, column 29005 in <anonymous function: z>() in http://website.co.uk/wp-includes/js/jquery/jquery.js?ver=1.6.1:
        c.removeEventListener("DOMContentLoaded",z,!1),e.ready()

    i tried your edit in the plugin folder misc:list-images-single-post.php

    my code in the template is:
    <?php easy_nivo_slider_for_featured_images(array('category'=>'HomeSlider','effect'=>'fade','transition'=>'1000','pause'=>'5000')); ?>

    which has worked very well in other sites.

    The first image is on the page but there is no sliding / swapping of images.
    tom

  3. jquindlen
    Member
    Posted 3 years ago #

    Same issue!

  4. Daniel Payne
    Member
    Posted 3 years ago #

    I fixed my installation by editing the file: plugins/easy-nivo-slider/3rd-party/jquery.nivo.slider.js

    I commented out line 97:

    [code]if(title.substr(0,1) == '#') title = $(title).html();[/code]

    My Nivo slider is now working and even previews OK.

  5. CarstenTimm
    Member
    Posted 3 years ago #

    The fix suggested by Daniel Payne worked for me, but my slider images did not look good after implementing the fix, they all got a black bar underneath.

    I then downloaded the newest version of the Nivo Slider from http://nivo.dev7studios.com/ and updated the three files in the folder plugins/easy-nivo-slider/3rd-party/ - This worked great for me.

    Hope that it can help others in this situation.

  6. dekoded
    Member
    Posted 3 years ago #

    I was having the same issues, no sliding images unless the 'caption' option is enabled.

    As CarstenTimm says, just go here: http://nivo.dev7studios.com/pricing/

    and download the free version, extract the 3 files:

    nivo-slider.css
    jquery.nivo.slider.pack.js
    jquery.nivo.slider.js

    from the nivo slider folder, replace the existing files in the folder plugins/easy-nivo-slider/3rd-party/ on your server and all should work!

    Thanks CarstenTimm.

  7. illusiodesign
    Member
    Posted 2 years ago #

    Just implemented this fix and it's working with no problems.

  8. MyrddinDE
    Member
    Posted 2 years ago #

    Thanks Dekoded, this helped my issue aswell.

    The Slider was displaying pictures that were no longer marked as featured. The old ones are no longer displayed after updating the css, js files form the new nivo-free package

  9. Kieran McCarthy
    Member
    Posted 2 years ago #

    dekoded's solution worked for me. Thanks

  10. kjparish
    Member
    Posted 2 years ago #

    It's been a couple of months now, but I just did a fresh install of WP and the plugin, which was also broken. Dekoded's solution just worked for me also. Thanks!

  11. ssalter
    Member
    Posted 2 years ago #

    *thumbs up* ... been on FB too damn much, Dekoded, I LIKED your solution. Worked like a charm.

  12. meninoebom
    Member
    Posted 2 years ago #

    Wow. Big help. Thanks.

  13. tomwgf
    Member
    Posted 2 years ago #

    Still using Dekoded's solution through all updates - now on 3.3.1.

    You do not need it, it seems, if you want text/captions over your images.

    But if you want the images to slide with no text then replace the 3 files as instructed

Topic Closed

This topic has been closed to new replies.

About this Plugin

About this Topic