WordPress.org

Ready to get started?Download WordPress

Forums

MimeTypes Link Icons
winrar not supported? (36 posts)

  1. spiney
    Member
    Posted 9 months ago #

    i dont see .rar in supported list .
    but i see .tar, .zip included.. could you please add .rar ?

    i did see .ra but i dont think that's the same thing? or is it typo?

    http://wordpress.org/plugins/mimetypes-link-icons/

  2. jrf
    Member
    Plugin Contributor

    Posted 9 months ago #

    .ra = real audio, so no, that's not the same thing.

    It's definitely one to consider for the next version.
    Could you please open a feature request issue on GitHub for this ?

    Thanks.

  3. spiney
    Member
    Posted 9 months ago #

    i got page not found error whenever I tried to create a ticket

    https://github.com/eagerterrier/MimeTypes-Link-Icons/issues/new

  4. jrf
    Member
    Plugin Contributor

    Posted 9 months ago #

    @steeltape could you please try again ? This might have been a temporary hickup on GitHub.

    [Edit] Sorry, I just notice that you did actually open the ticket. Thanks!

  5. spiney
    Member
    Posted 8 months ago #

    hi, still no .rar supported?

  6. jrf
    Member
    Plugin Contributor

    Posted 8 months ago #

    @steeltape, sorry not yet, though I have prepped the code for a new release, hoping @eagerterrier will find some time in the near future to create the new icons (yours is not the only open request).

  7. eagerterrier
    Member
    Plugin Author

    Posted 8 months ago #

    @steeltape - just done the designs and added icons. v3.2 should be up tomorrow. I'll post here and on git when it's released.

    Thanks for your patience.

  8. spiney
    Member
    Posted 8 months ago #

    got the update. thanks

  9. eagerterrier
    Member
    Plugin Author

    Posted 8 months ago #

    @steeltape - just to confirm, v3.2 went live this morning.

    If you have any problems, let us know, otherwise please mark topic as resolved

  10. spiney
    Member
    Posted 8 months ago #

    ah.. sadly it doesn't seem to show icon when we choose link to attachment page.

  11. eagerterrier
    Member
    Plugin Author

    Posted 8 months ago #

    @steeltape - can you send me a link? I've tested on my version and the .rar is showing fine.

    Did you update via the WP admin area?

  12. spiney
    Member
    Posted 8 months ago #

    here. yes I did set it up in admin area.

    minedl.com/minecraft-speak-and-spell-1-7-2-map/3431/minecraft-speak-and-spell-by-rsmalec/

  13. eagerterrier
    Member
    Plugin Author

    Posted 8 months ago #

    @steeltape - Seems like a plugin is overriding your hyperlinks.

    1. The URL in the source is written like so

    <a href='http://www.minedl.com/wp-content/uploads/2013/12/Minecraft-Speak-and-Spell-by-rsmalec.zip'>Minecraft Speak and Spell by rsmalec</a>

    Once the page has rendered, the URL in your hyperlink reads like this

    <a href="#attachment">Minecraft Speak and Spell by rsmalec</a>

    Not sure how to go about fixing this..

  14. spiney
    Member
    Posted 8 months ago #

    add_action('wp_footer', 'hide_attachment_links');
    function hide_attachment_links () {
      if (is_attachment()) { ?>
    <script>jQuery(function($){
        $('a[href*="/uploads/"][href$=".zip"],a[href*="/uploads/"][href$=".rar"]').each( function() {
            $(this).data('href', $(this).attr('href'));
            $(this).attr('href','#attachment');
        });
        $('a[href="#attachment"]').click( function(e) {
            e.preventDefault();
            location.href = $(this).data('href');
        });
    });</script>
    <?php
      }
    }

    i'm using this .. so it won't work with this intact?

  15. eagerterrier
    Member
    Plugin Author

    Posted 8 months ago #

    @steeltape - If it's JS and you are NOT using the async method, then it should work fine, but make sure you have the .zip ticked in the plugin settings.

    If I can ask that you check your plugin settings and get back to me, I can then replicate the problem if you're still having difficulties

  16. spiney
    Member
    Posted 8 months ago #

    yes I already tick zip n rar in settings..

  17. eagerterrier
    Member
    Plugin Author

    Posted 8 months ago #

    @steeltape - how about async settings? They're right at the bottom under a heading called 'Enable Asynchronous Replacement?'

  18. spiney
    Member
    Posted 8 months ago #

    I enable both just now enable async and enable debug
    still not showing.

    It however work with direct link to files like in this post

    minedl.com/minecraft-the-lost-potato-secret-chambers-map/3537/

  19. eagerterrier
    Member
    Plugin Author

    Posted 8 months ago #

    @steeltape - can you disable async, disable debug, disable 'Enable/Disable classnames?' and disable 'Show File Size' too?

    I want to see what happens when all mime type JS is removed.

  20. spiney
    Member
    Posted 8 months ago #

    nope. still nothing..
    Guess the code I'm using is no good with mime plugin

  21. eagerterrier
    Member
    Plugin Author

    Posted 8 months ago #

    @steeltape - don't give up yet.

    It's definitely not your code above (I turned off JS and the plugin functionality still isn't working), but it appears to be because this is on an attachment page itself.

    What I'll do is look into the hooks for attachment pages and try and see if we can't get a patch to you in the next few days.

  22. eagerterrier
    Member
    Plugin Author

    Posted 8 months ago #

    @steeltape - OK, I've looked at attachment pages on a couple of my sites and it seems to be working just fine.

    Can you tell me what version you see on your mime type settings page (should be bottom right)?

    Also, do you have any other plugins that run only on attachment pages?

    Have you tried commenting out your code above?

  23. spiney
    Member
    Posted 8 months ago #

    I haven't but it work on other direct link files so if I commented out it should work but that beats the purpose of my site >_<

    the latest version. I havent install your plugin till you guys update it with winrar. no other plugins on attachment page

  24. jrf
    Member
    Plugin Contributor

    Posted 8 months ago #

    @steeltape Can you give me a screenshot of your settings ? (or just make a copy of the settings at the bottom of the settings page if you have WP_DEBUG enabled).

    Also: are you a developer ? Is so, could you check what actions and filters are registered to the the_content hook on the attachment page ?

  25. spiney
    Member
    Posted 8 months ago #

    here you go

    array(96) {
      ["internal_domains"]=>
      array(2) {
        [0]=>
        string(7) "www.min"
        [1]=>
        string(3) "min"
      }
      ["image_size"]=>
      string(2) "24"
      ["image_type"]=>
      string(3) "png"
      ["leftorright"]=>
      string(4) "left"
      ["show_file_size"]=>
      bool(false)
      ["precision"]=>
      int(2)
      ["use_cache"]=>
      bool(true)
      ["cache_time"]=>
      int(604800)
      ["enable_async"]=>
      bool(false)
      ["enable_async_debug"]=>
      bool(false)
      ["enable_hidden_class"]=>
      bool(false)
      ["hidden_classname"]=>
      array(1) {
        [0]=>
        string(10) "wp-caption"
      }
      ["version"]=>
      string(3) "3.2"
      ["enable_3g2"]=>
      bool(false)
      ["enable_3gp"]=>
      bool(false)
      ["enable_ai"]=>
      bool(false)
      ["enable_air"]=>
      bool(false)
      ["enable_asf"]=>
      bool(false)
      ["enable_avi"]=>
      bool(false)
      ["enable_bib"]=>
      bool(false)
      ["enable_cls"]=>
      bool(false)
      ["enable_csv"]=>
      bool(false)
      ["enable_deb"]=>
      bool(false)
      ["enable_djvu"]=>
      bool(false)
      ["enable_dmg"]=>
      bool(false)
      ["enable_doc"]=>
      bool(false)
      ["enable_docx"]=>
      bool(false)
      ["enable_dwf"]=>
      bool(false)
      ["enable_dwg"]=>
      bool(false)
      ["enable_eps"]=>
      bool(false)
      ["enable_epub"]=>
      bool(false)
      ["enable_exe"]=>
      bool(false)
      ["enable_f"]=>
      bool(false)
      ["enable_f77"]=>
      bool(false)
      ["enable_f90"]=>
      bool(false)
      ["enable_flac"]=>
      bool(false)
      ["enable_flv"]=>
      bool(false)
      ["enable_gif"]=>
      bool(false)
      ["enable_gz"]=>
      bool(false)
      ["enable_ico"]=>
      bool(false)
      ["enable_indd"]=>
      bool(false)
      ["enable_iso"]=>
      bool(false)
      ["enable_jpg"]=>
      bool(false)
      ["enable_jpeg"]=>
      bool(false)
      ["enable_log"]=>
      bool(false)
      ["enable_m4a"]=>
      bool(false)
      ["enable_m4v"]=>
      bool(false)
      ["enable_midi"]=>
      bool(false)
      ["enable_mkv"]=>
      bool(false)
      ["enable_mov"]=>
      bool(false)
      ["enable_mp3"]=>
      bool(false)
      ["enable_mp4"]=>
      bool(false)
      ["enable_mpeg"]=>
      bool(false)
      ["enable_mpg"]=>
      bool(false)
      ["enable_msi"]=>
      bool(false)
      ["enable_odp"]=>
      bool(false)
      ["enable_ods"]=>
      bool(false)
      ["enable_odt"]=>
      bool(false)
      ["enable_oga"]=>
      bool(false)
      ["enable_ogg"]=>
      bool(false)
      ["enable_ogv"]=>
      bool(false)
      ["enable_pdf"]=>
      bool(true)
      ["enable_png"]=>
      bool(false)
      ["enable_pps"]=>
      bool(false)
      ["enable_ppsx"]=>
      bool(false)
      ["enable_ppt"]=>
      bool(false)
      ["enable_pptx"]=>
      bool(false)
      ["enable_psd"]=>
      bool(false)
      ["enable_pub"]=>
      bool(false)
      ["enable_py"]=>
      bool(false)
      ["enable_qt"]=>
      bool(false)
      ["enable_ra"]=>
      bool(false)
      ["enable_ram"]=>
      bool(false)
      ["enable_rar"]=>
      bool(true)
      ["enable_rm"]=>
      bool(false)
      ["enable_rpm"]=>
      bool(false)
      ["enable_rtf"]=>
      bool(false)
      ["enable_rv"]=>
      bool(false)
      ["enable_skp"]=>
      bool(false)
      ["enable_spx"]=>
      bool(false)
      ["enable_sql"]=>
      bool(false)
      ["enable_sty"]=>
      bool(false)
      ["enable_tar"]=>
      bool(false)
      ["enable_tex"]=>
      bool(false)
      ["enable_tgz"]=>
      bool(false)
      ["enable_tiff"]=>
      bool(false)
      ["enable_ttf"]=>
      bool(false)
      ["enable_txt"]=>
      bool(false)
      ["enable_vob"]=>
      bool(false)
      ["enable_wav"]=>
      bool(false)
      ["enable_wmv"]=>
      bool(false)
      ["enable_xls"]=>
      bool(false)
      ["enable_xlsx"]=>
      bool(false)
      ["enable_xml"]=>
      bool(false)
      ["enable_xpi"]=>
      bool(false)
      ["enable_zip"]=>
      bool(true)
    }

    Thank you for creating with WordPress.

    Get Version 3.8

    code wasn't made by me. My theme designer created that : vfxdude.com

  26. jrf
    Member
    Plugin Contributor

    Posted 8 months ago #

    @steeltape I've tried to reproduce the issue using the exact same settings you are using including the js snippet and I still can't.

    To be fair: I don't think this is a problem with our plugin, but rather a problem with another plugin and/or theme interfering.
    Having said that, I will try and help you further, though - again - this is *not* a problem with MTLI.

    Let's have a look at the theme first. Have a look at this info in the codex and see which templates your theme includes and which is being used by your theme to display the attachment page for .zip/.rar.

    See if that file actually calls the_content(). If it doesn't, but adds the attachments in another way, that's your problem.
    If it does, we need to look further.

  27. spiney
    Member
    Posted 8 months ago #

    yes it does calls the_content()

    <?php get_header(); ?>
    <?php the_post() ?>
        <div class="attachment">
            <?php the_attachment_link($post->post_ID, true) ?>
            <?php the_content(); ?>
        </div>
        <?php comments_template(); ?>
    
    <?php get_footer() ?>

    we do have
    attachment.php
    single.php
    index.php

    I have also tried disabling all other plugins and leaving only MLTI, still not showing.

  28. jrf
    Member
    Plugin Contributor

    Posted 8 months ago #

    That seems to look ok. Now what's in the action/filter queue for the_content on your attachment page ? is our filter in there or has it been removed somehow ?

  29. spiney
    Member
    Posted 8 months ago #

    how do I check that?

  30. jrf
    Member
    Plugin Contributor

    Posted 8 months ago #

    Easiest way is probably with a combination of two plugins:
    Debug Bar and Debug Bar actions & filters.

    Please use version 1.1 of the latter (you can download it from the developers tab) as the last two versions contain a bug which prevents most actions/filters from showing (or use this fixed version - manual install needed).

    Once you have both those installed, go to an attachment page and while on that page, click on "debug" in the admin bar and go to the "Filter hooks" tab. Search for the_content and see what's there.

Reply »

You must log in to post.

About this Plugin

About this Topic