WordPress.org

Ready to get started?Download WordPress

Forums

Slideshow
Where can I submit patches? (10 posts)

  1. poorgeek
    Member
    Posted 1 year ago #

    I really like how easy it is to use this slideshow, but I need to make the controls (prev/next, navigation and play/pause) accessible. Where can I submit patches?

    http://wordpress.org/extend/plugins/slideshow-jquery-image-gallery/

  2. Stefan Boonstra
    Member
    Plugin Author

    Posted 1 year ago #

    What exactly do you mean by making them accessible? I could send you the PhotoShop files if you'd like me to.

  3. poorgeek
    Member
    Posted 1 year ago #

    For starters, a user should be able to navigate to and use each of the buttons using only a keyboard. Each of the buttons must also be described in some way so that a blind user can find them.

    I'm just about done updating the pause/play buttons to work this way and can send you a patch if you'd like to see what I mean.

  4. Stefan Boonstra
    Member
    Plugin Author

    Posted 1 year ago #

    That would be great! Could you please send me an e-mail at wordpress@stefanboonstra.com or create a GitHub repository with the adapted code?

  5. bensashi
    Member
    Posted 8 months ago #

    Stefan, I work with poorgeek - I sent an email to the address listed above regarding the best way we could contribute our changes to the plugin. Unfortunately due to the concatenation/minification of all the JavaScript in recent plugin releases, it's difficult to apply some of the fixes we made.

    If you have time to respond to that email I'd really appreciate it - thanks!

  6. Stefan Boonstra
    Member
    Plugin Author

    Posted 8 months ago #

    Hi Ben,

    If you don't mind, I'll answer your question in this thread.

    All of the slideshow plugin's files can already be found on GitHub. To be able to compile the slideshow's script to a single file again, you'll need a tool like Prepros or CodeKit.

    Best regards,
    Stefan

  7. bensashi
    Member
    Posted 8 months ago #

    Stefan,

    Thanks very much. I had found what I thought was your GitHub account, but it must have been someone else, and there were no public repositories.

    I will work on a pull request with our changes.

    Ben

  8. Stefan Boonstra
    Member
    Plugin Author

    Posted 8 months ago #

    Hi Ben,

    That's great, I'll await your pull request. Thank you very much.

    Best regards,
    Stefan

  9. bensashi
    Member
    Posted 8 months ago #

    I'm not familiar with CodeKit but I understand conceptually what it's for. Do you use the default settings for things like minification or have you changed anything in preferences? I guess it doesn't matter too much - I can just contribute the original source files and leave the minification/concatenation to you when you review the changes.

  10. Stefan Boonstra
    Member
    Plugin Author

    Posted 8 months ago #

    It doesn't matter too much indeed. I use Prepros myself, as I'm on Windows. However, I haven't changed any settings for minification.

    As long as the "js/min/all.frontend.min.js" and "js/min/all.backend.min.js" are created, the slideshow will work.

Topic Closed

This topic has been closed to new replies.

About this Plugin

About this Topic

Tags

No tags yet.