Forums

MP3-jPlayer
v1.7.1 - 2 missing files, and any plans to make a sprite? (6 posts)

  1. digitaltoast
    Member
    Posted 11 months ago #

    Hello! This works well, but a couple of questions:

    First of all, it seems that

    /blog/wp-content/plugins/mp3-jplayer/css/images/pos-handleH.gif
    /blog/wp-content/plugins/mp3-jplayer/css/images/pos-handle3.gif

    are missing from the download. Secondly, I get quite a big hit on Google Pagespeed because the following images should be css sprites:

    buttons-popout4.png
    buttons-popout4H.png
    case2dark-l.png
    case2dark-r.png
    case2dark-x.png
    inlineHandle.gif
    inlineHandleCH.png
    inlineHandleCH2.png
    inlineHandleH.gif
    pl-darken1.png
    pos-handle3.gif
    pos-handle3H.gif
    vol-grad60b2.png
    vol-handle2.gif
    vol-handleH.gif

    That's 15 images which could be one.

    Are there any plans to make this a sprite? Is anyone else working on it? If no, I might have a go at it myself.

    Thanks for a great plugin anyway!

  2. Moogle Stiltzkin
    Member
    Posted 11 months ago #

    I have this same exact issue. Firebug on firefox is reporting these 2 files with the error message that digial toast posted.

    Is there any fix for that ?

  3. Moogle Stiltzkin
    Member
    Posted 11 months ago #

    By the way i just did a fresh clean install of wordpress, and yet i also get this problem.

  4. simon.ward
    Member
    Posted 8 months ago #

    Apologies, those missing image errors are fixed for next release.

    A lot of the images can't be sprited as they are tiled/repeated. If I can get round to it i will merge the transport button graphics to 1 file...

    Simon

  5. digitaltoast
    Member
    Posted 8 months ago #

    Hi Simon,

    Good to see you back. When you talk about "next release", are you going to include the 2.1 version of jplayer?

    Also, when you say "a lot of the images can't be sprited as they are tiled/repeated" - you can tile or repeat any part of a sprite.

    As far as the icons go, you don't even need to include any icons at all - if you go with one of the jqueryui themes hosted by Google, then they take care of all the icons, css etc for you. See here for more:

    http://encosia.com/do-you-know-about-this-undocumented-google-cdn-feature/

  6. simon.ward
    Member
    Posted 8 months ago #

    hi toast,

    yes i'm planning to move to v2, hopefully i'll get a decent chunk of time to play with this soon.

    With sprites, that's not true. If you try and map out a sprite for this you'll see it will be huge, wasteful, and effectively impose limits on the sizes of some elements.

    With hosted ui, well i'd lose my graphics! Also that 50KB of CSS, 99% of which I don't need.

    Simon

Reply

You must log in to post.

About this Plugin

About this Topic