WordPress.org

Ready to get started?Download WordPress

Forums

Admin Menu Editor
[resolved] UI bug when changing menu icon (17 posts)

  1. Hassan
    Member
    Posted 1 year ago #

    There's an awkward bug when you want to change the icon of any menu. The icon selection box appears waaaay down at the bottom of the screen causing an annoying eyesore.

    http://wordpress.org/extend/plugins/admin-menu-editor/

  2. Janis Elsts
    Member
    Plugin Author

    Posted 1 year ago #

    What browser and WordPress version are you using? I tested the plugin with the latest versions of IE, Opera and Chrome and didn't notice any problems.

  3. Hassan
    Member
    Posted 1 year ago #

    I've tested this in latest versions of both Firefox and Chrome. WP 3.5.1
    Screenshot: http://i.imgur.com/L2NN2Lz.jpg?1

  4. Janis Elsts
    Member
    Plugin Author

    Posted 1 year ago #

    I just (re-)tested it in Firefox 20.0 and Chrome 26.0.1410.43 and the icon selector still looks fine on my end.

    Maybe there's another factor at work here, like a plugin conflict. Try temporarily deactivating other plugins and see if it fixes the problem. Also, check your JavaScript console for error messages while on the menu editor page.

  5. Hassan
    Member
    Posted 1 year ago #

    Deactivated all plugins (except AME of course) and switched to default theme-- still having this issue. Also, there are no errors in the console. Not exactly sure what's causing this.

  6. Janis Elsts
    Member
    Plugin Author

    Posted 1 year ago #

    Sorry, I'm drawing a blank here as well.

    Do you have any web development experience? Maybe you could try looking at the selection box in Firefox dev tools (i.e. "Inspect element") and see if you can figure out why the box contents get pushed down to the bottom of the page like that. I'm guessing that the upper-left corner is in the right place, but the element height is messed up for some reason.

    At least that's what I would do if I had access to the site.

  7. Hassan
    Member
    Posted 1 year ago #

    Janis, that's one of the first things I did; I'm a web designer/developer :D

    However, I did not figure it out at first. But I just tried again and noticed that there is inline CSS styles applied to the #ws_icon_selector div: position: relative; top: 588px; left: 121px;

    If I change the position from relative to absolute, the selection box returns to its normal place.

    Still unsure what's the cause :\

  8. Janis Elsts
    Member
    Plugin Author

    Posted 1 year ago #

    Those inline styles are set by the $.position() utility function that I use to position the selection box below the icon button. Sounds like it produces incorrect results in your case. Maybe an old version of jQuery / jQuery UI is being loaded for some reason (e.g. failed upgrade)?

    Interestingly, on my sites the "top" property is always negative. For example: "position: relative; top: -770px; left: 119px;". What happens if you flip the sign instead of changing it to "position: absolute"?

  9. Hassan
    Member
    Posted 1 year ago #

    Not quite sure what you mean by "flip the sign"

  10. Janis Elsts
    Member
    Plugin Author

    Posted 1 year ago #

    As in, change the value of the "top" property from positive to negative.

  11. Hassan
    Member
    Posted 1 year ago #

    That still messes up the position. Not helpful.

  12. Janis Elsts
    Member
    Plugin Author

    Posted 1 year ago #

    Lets see if setting position to absolute in the stylesheet helps fix the problem. As far as I can tell, jQuery will not change it to relative if it is already explicitly specified, and everything still seems to work fine on the test site.

    Try the development version.

  13. Hassan
    Member
    Posted 1 year ago #

    Oh, yeah. That works!

  14. Hassan
    Member
    Posted 1 year ago #

    Hey, Janis. So, aren't you releasing an updated version with this fix?

  15. Janis Elsts
    Member
    Plugin Author

    Posted 1 year ago #

    I certainly will. I guess I'm just somewhat biased against releasing a whole new version for one small bugfix, so I've been holding off on it.

  16. Hassan
    Member
    Posted 1 year ago #

    Heh, yeah I know. Just make sure you shove in more cool features as well in the next big awesome update ;-)

  17. Hassan
    Member
    Posted 1 year ago #

    Hi Janis,

    Just updated to v1.2.1 and this UI bug appears to be squashed. Thanks!
    Also, was about to report to you the icon alignment issue with MP6 plugin, but looks like you've already polished that as well :)

Topic Closed

This topic has been closed to new replies.

About this Plugin

About this Topic