WordPress.org

Ready to get started?Download WordPress

Forums

[resolved] twentytwelve nav (23 posts)

  1. Amit Kvint
    Member
    Posted 1 year ago #

    some strange float problem when adding a question mark to one of the main nav items (class="nav-menu"), when doing that it breaks the height of the line and the items become to high and breaks the nav line example here - atwild.com

    I have tried with other characters but seems to work fine : )

    Amit

  2. Nathan Driver
    Member
    Posted 1 year ago #

    when I translate the page the nav comes out right - seems something is lost in the translation code.

  3. Amit Kvint
    Member
    Posted 1 year ago #

    Hi,

    What do you mean translate ? I don't think I have installed WPML or qTranslate on that domain,

    Thanks,

    Amit

  4. Nathan Driver
    Member
    Posted 1 year ago #

    sorry - translate w/ google chrome.

  5. Amit Kvint
    Member
    Posted 1 year ago #

    ah ok

    Still normal nav is broken if you don't translate right ?

  6. Nathan Driver
    Member
    Posted 1 year ago #

    correct

  7. mindctrl
    Member
    Posted 1 year ago #

    I don't see what you're talking about.

    Screen shot

  8. Nathan Driver
    Member
    Posted 1 year ago #

    weird b/c this is what i'm seeing

    Screen shot

  9. mindctrl
    Member
    Posted 1 year ago #

    Which browser are you using? I tested in Firefox and Safari and it worked fine here in both.

  10. Nathan Driver
    Member
    Posted 1 year ago #

    Chrome

  11. mindctrl
    Member
    Posted 1 year ago #

    I see what you see in Chrome. That's weird. Removing the space before the ? fixes it in Chrome. That could be a temp workaround. I'd say that's some sort of bug in Chrome.

  12. Lance Willett
    Theme Wrangler
    Posted 1 year ago #

    That's a weird one! I can repeat it with any single character after a space, like Home A but not Home AB.

    Worth a Trac ticket, for sure. I can't find the issue with a quick debug.

  13. mindctrl
    Member
    Posted 1 year ago #

    Changing this:
    .main-navigation li a, .main-navigation li

    from display: inline-block to display: inline fixes it, but I didn't test it to see if there are unintended consequences.

  14. https://core.trac.wordpress.org/ticket/22088 for you :)

    It's still a problem today, so I made that change into patch (credit mindctrl!)

  15. Nathan Driver
    Member
    Posted 1 year ago #

    looks like the same info is posted on the fix:

    Changing this:

    .main-navigation li a,
    .main-navigation li {
    display: inline-block;
    text-decoration: none;
    }
    to this

    .main-navigation li a,
    .main-navigation li {
    display: inline-block;
    text-decoration: none;
    }
    fixes it (credit mindctrl)

  16. The patch was right ;) But it breaks submenus so ... we fixed the desc

  17. Amit Kvint
    Member
    Posted 1 year ago #

    I have just looked at that again and that's a real weird one!
    the <li class="page_item page-item-[number]"> some text ?Seems to be just fine.I mean just a normal NAV with list items as you do.

    I wonder if there was anything else changed for the NAV compared to 2011 for example (will look at that briefly).
    Anyway any chance that's some kind of a Chrome bug ? inline-block does seems to create that problem, but couldn't find any reference as to a known issue with that.

    Keep digging : )
    Amit

  18. mindctrl
    Member
    Posted 1 year ago #

    Can you guys test this one?

    .main-navigation li a,
    .main-navigation li {
        display: inline;
        text-decoration: none;
    }
    
    .main-navigation ul.sub-menu li {
        display: list-item;
    }
  19. mindctrl
    Member
    Posted 1 year ago #

    Scratch that previous comment. It breaks in other browsers.

    Can you all try this one and see if you find any oddities with it?

    .main-navigation li a,
    .main-navigation li {
        display: inline-block;
        text-decoration: none;
        white-space: nowrap;
    }
  20. It should be fixed now in core.

  21. Amit Kvint
    Member
    Posted 1 year ago #

    Yes that one seems to work!

  22. Lance Willett
    Theme Wrangler
    Posted 1 year ago #

    Hi all, this is fixed now in the core WP trunk repository, see http://core.trac.wordpress.org/changeset/22296

    It'll be in the next main Extend theme release (not sure exactly when, probably mid-November).

  23. wallie007
    Member
    Posted 1 year ago #

    ah, I was looking for exact this problem, Seems to be time to upgrade my installation!

Topic Closed

This topic has been closed to new replies.

About this Topic