WordPress.org

Ready to get started?Download WordPress

Forums

[resolved] twentyten ten child-theming: remove_action in functions.php (9 posts)

  1. nusi
    Member
    Posted 3 years ago #

    hi,

    i'm currently designing a child-theme for twentyten and i recently hit an issue i don't understand. i'm using wordpress' built-in post-thumbnails mechanism but i want a different imagesize than the one defined in twentyten_setup.
    so i did the following:

    if ( function_exists( 'twentyten_setup' )) {
    	remove_action('after_setup_theme', 'twentyten_setup');
    }
    
    add_action( 'after_setup_theme', 'mytheme_setup' );
    
    if(!function_exists('mytheme_setup')):
    
    function mytheme_setup() {
    	add_theme_support( 'post-thumbnails' );
    	define( 'TEASER_IMAGE_WIDTH', apply_filters( 'myteaser_teaser_image_width', 938 ) );
    	define( 'TEASER_IMAGE_HEIGHT', apply_filters( 'myteaser_teaser_image_height', 420 ) );
    	set_post_thumbnail_size( TEASER_IMAGE_WIDTH, TEASER_IMAGE_HEIGHT, true );
    }
    
    endif;

    ... this already worked for me once. i don't know what really happened - this was under wp 3.0.1. i've upgraded to wp 3.0.3 meanwhile. but i somehow doubt that this caused my problem.

    what else could i have done wrong?

    however, i don't quite get how the childtheme-mechanism is supposed to work regarding functions.php. http://codex.wordpress.org/Child_Themes explicitely mentions the following:

    Unlike style.css, the functions.php of a child theme does not override its counterpart from the parent. Instead, it is loaded in addition to the parent’s functions.php. (Specifically, it is loaded right before the parent’s file.)

    so, how should the following line (in my functions.php file) work

    if ( function_exists( 'twentyten_setup' )) {
    	remove_action('after_setup_theme', 'twentyten_setup');
    }

    if the file that contains 'twentyten' setup is loaded after my the childtheme's functions.php?

    thanks, stefan

  2. Root
    Member
    Posted 3 years ago #

    Well u dont want to remove the function. You want to edit its contents. To do that use a filter. Although child themes functions load later they can replace the earlier function............

  3. esmi
    Forum Moderator
    Posted 3 years ago #

    Remove:

    if ( function_exists( 'twentyten_setup' )) {
    	remove_action('after_setup_theme', 'twentyten_setup');
    }

    Change:

    if(!function_exists('mytheme_setup')):
    
    function mytheme_setup() {
    	add_theme_support( 'post-thumbnails' );
    	define( 'TEASER_IMAGE_WIDTH', apply_filters( 'myteaser_teaser_image_width', 938 ) );
    	define( 'TEASER_IMAGE_HEIGHT', apply_filters( 'myteaser_teaser_image_height', 420 ) );
    	set_post_thumbnail_size( TEASER_IMAGE_WIDTH, TEASER_IMAGE_HEIGHT, true );
    }
    
    endif;

    to:

    function mytheme_setup() {
    	add_theme_support( 'post-thumbnails' );
    	define( 'TEASER_IMAGE_WIDTH', apply_filters( 'myteaser_teaser_image_width', 938 ) );
    	define( 'TEASER_IMAGE_HEIGHT', apply_filters( 'myteaser_teaser_image_height', 420 ) );
    	set_post_thumbnail_size( TEASER_IMAGE_WIDTH, TEASER_IMAGE_HEIGHT, true );
    }

    Are you defining TEASER_IMAGE_WIDTH andTEASER_IMAGE_HEIGHT elsewhere?

  4. nusi
    Member
    Posted 3 years ago #

    thanks to you both for your quick replies,

    @root: that sounds reasonable. however, i'm a bit puzzled on how to do that. i tried something like the following:

    remove_filter('twentyten_header_image_width', 'twentyten_setup');
    remove_filter('twentyten_header_image_height', 'twentyten_setup');
    
    add_filter('soho_teaser_image_width', 'twentyten_setup');
    add_filter('soho_teaser_image_height', 'twentyten_setup');

    but then, there are still the 3 lines below in twentyten_setup() which i thought i would elimenate by calling :

    remove_action('after_setup_theme', 'twentyten_setup');
    define( 'HEADER_IMAGE_WIDTH', apply_filters( 'twentyten_header_image_width', 940 ) );
    define( 'HEADER_IMAGE_HEIGHT', apply_filters( 'twentyten_header_image_height', 198 ) );
    set_post_thumbnail_size( HEADER_IMAGE_WIDTH, HEADER_IMAGE_HEIGHT, true );

    ... and replacing it by my custom setup-function.

    could you (or anyone else) give me an example that is a bit more explicite?

    @esmi: that didn't have any effect. function_exists() simply checks if some function is defined, before you try do something with it. it's very unlikely that my custom setup-function already exists. however, checking ahead shouldn't harm and anyway, how should it change the output of my function?

    thanks, stefan

  5. esmi
    Forum Moderator
    Posted 3 years ago #

    function_exists() simply checks if some function is defined

    I'm aware of that - which is why you shouldn't be using it in a child theme. Instead of creating custom functions, you should be looking at re-writing the parent theme's functions within the child.

  6. nusi
    Member
    Posted 3 years ago #

    ... seems like i found a way:

    in my functions.php i did the following:

    if(!function_exists('twentyten_setup')):
    	add_action( 'after_setup_theme', 'twentyten_setup' );
    
    function twentyten_setup() {
    	define( 'TEASER_IMAGE_WIDTH', apply_filters( 'soho_teaser_image_width', 938 ) );
    	define( 'TEASER_IMAGE_HEIGHT', apply_filters( 'soho_teaser_image_height', 420 ) );
    	set_post_thumbnail_size( TEASER_IMAGE_WIDTH, TEASER_IMAGE_HEIGHT, true );
    
    }
    
    endif;

    so, it looks like a twentyten child-teme's setup-function still has to be named twentyten_setup() - and it's simply gonna 'overload' the parent's theme setup-function. kinda weird, but ok. it works now. this thread gave me the hint.

    thanks again, stefan

  7. esmi
    Forum Moderator
    Posted 3 years ago #

    kinda weird, but ok

    That's how it's designed to work. WP looks in the child theme first and only looks in the parent if it can't find the relevant function or template. So you only need to store your customisations in the child theme.

  8. nusi
    Member
    Posted 3 years ago #

    well, would i meant by 'weird' is the fact that you usually can't redeclare a function which at first sight is what i do in my functions.php. e.g. the following triggers an error

    <?php
    	function my_fancy_function() {
    		echo "blah";
    	}
    
    	function my_fancy_function() {
    		echo "blub";
    	}
    
    	my_fancy_function();
    ?>

    ... but yes, we're not discussing php-concepts here and i'm happy it works now. and i also understand your first reply now - i was just missing the context.

    best, stefan

  9. esmi
    Forum Moderator
    Posted 3 years ago #

    you usually can't redeclare a function

    You can if the parent's function.php always uses if(!function_exists( 'foobar') ) [...] endif; around each of its functions. That's part of making the parent child-theme-aware. :-)

Topic Closed

This topic has been closed to new replies.

About this Topic