WordPress.org

Ready to get started?Download WordPress

Forums

[resolved] Theme Development - Theme Check Errors (6 posts)

  1. sabahat
    Member
    Posted 3 years ago #

    Hi,

    I'm using Theme Check to help with my first WordPress theme, and I am down to just a few issues. I am not sure how to resolve some of them and I need help!

    The first error I get is for comment_form. My form is a part of the comments template, so should I ignore this error?

    I also get this recommendation:

    RECOMMENDED: Text domain problems in footer.php. You have not included a text domain!

    Line 30: <td width='97'><a href='<?php bloginfo('rss2_url'); ?>' title='<?php _e('Syndicate this site using RSS'); ?>'><img src='<?php echo get_template_

    What text link should I be adding here? Can anyone help? I found something about textdomains related to translations. Do I have to add the rss domain in the string?

    Thanks in advance,

    Sabahat

  2. sabahat
    Member
    Posted 3 years ago #

    Just got my answer to the text domain issues, but I'm still looking for an answer to the comment_form error I get - should I take the form out of the comments template and make it a separate file?

  3. Chip Bennett
    Theme Review Admin
    Posted 3 years ago #

    Regarding the comment reply form: you should be using the comment_form() function to call the form. If you need to change the default behavior, use the many hooks available for modifying the comment form.

    Regarding textdomain: the problem is this bit:

    <?php _e('Syndicate this site using RSS'); ?>

    You need to provide a textdomain to the _e() function. Have you internationalized the rest of your Theme? If so, use the textdomain you defined in functions.php. Otherwise, if you're not internationalizing the entire Theme, replace this:

    title='<?php _e('Syndicate this site using RSS'); ?>'

    with this:

    title='Syndicate this site using RSS'

    Note: if the Theme is to be publicly released, you should use theme-slug as the textdomain. In other words, if your Theme name is "AwesomeSauce On A Bun", the theme-slug would be "awesomesauce-on-a-bun".

  4. Chip Bennett
    Theme Review Admin
    Posted 3 years ago #

    Just got my answer to the text domain issues, but I'm still looking for an answer to the comment_form error I get - should I take the form out of the comments template and make it a separate file?

    Take the comment reply form markup out of comments.php? YES

    Add a separate template file for the comment reply form markup? NO

    Use the comment_form() template tag, which adds the comment reply form markup for you.

  5. sabahat
    Member
    Posted 3 years ago #

    Thank you, Chip. Your help has been invaluable. I have internationalized the rest of the theme, I just didn't know what 'textdomain' referred to.

    I also want to know if I create a theme using a tutorial (Themeshaper: http://themeshaper.com/2009/06/24/creating-wordpress-theme-html-structure-tutorial/), and the code is obviously not written by me, is it eligible for review on the WordPress Theme Repository? I can safely say that the CSS is original, but the php code is mostly from the tutorial and from the WordPress Codex.

  6. Chip Bennett
    Theme Review Admin
    Posted 3 years ago #

    Using a tutorial like that is a great place to start. There is nothing "creative" there; it's essentially all functional. So, I wouldn't worry about the code not being "yours". The Theme will still be what you make of it, after starting with that basic HTML structure.

    So, that's the long-winded way to say: using that tutorial does not preclude your Theme from being considered for the repository.

Topic Closed

This topic has been closed to new replies.

About this Topic