WordPress.org

Ready to get started?Download WordPress

Forums

Theme Denied (18 posts)

  1. vicdesigns
    Member
    Posted 3 years ago #

    I have created two themes. One is still pending approval or denial. No doubt it will be the latter.
    My other theme was denied today for the following reasons:

    They said my theme was auto generated? Ummm hello!!! My themes are not auto generated. What an insult!

    Also:

    RECOMMENDED: Text domain problems in library/widgets.php. You have not included a text domain!

    Line 83: <h3 style='margin-bottom:3px;'><?php _e('Theme Options'); ?></h3>

    RECOMMENDED: Text domain problems in library/admins.php. You have not included a text domain!

    Line 8: <h2><?php _e('WPMotors Options'); ?></h2>

    RECOMMENDED: Text domain problems in functions.php. You have not included a text domain!

    Line 462: $title = $previous ? __('Previous Post') : __('Next Post');

    INFO: Possible hard-coded links were found in the file header.php.

    Line 49: <div class='vic-flash-alt'><a>

    I followed all guidelines and made sure that the theme passed all tests before submitting. It was your system that recommended the coding I am using, yet, you now say it is wrong? Again, Hello!!!!

    Maybe WordPress needs to review their submission guidelines rather than insult people with automated theme reviews?

    I would like to see what others feel before the Moderators close this thread just like they closed other threads of complaint.

    tata

  2. elfin
    Moderator
    Posted 3 years ago #

    text domain is optional I believe, plus the checker can only check some things, not all.

    Sounds like you wouldn't have much to do to change things to get it to pass. but I see no mention of the 'auto generated' accusation in your quote.

  3. vicdesigns
    Member
    Posted 3 years ago #

    Here is the full quote. And what really gives me the giggles is at the end they say "Leave a comment on the ticket" lol. I can't because they bloody closed it before I even got to read it.

    Changed 24 hours ago by pross

    * Owner set to pross
    * Status changed from new to assigned

    comment:2 Changed 23 hours ago by pross

    * Status changed from assigned to closed
    * Resolution set to not-approved

    Theme Review:

    * Themes should be reviewed using "define('WP_DEBUG', true);" in wp-config.php
    * Themes should be reviewed using the test data from the Theme Checklists (TC)

    WARNING: This theme appears to have been auto-generated. Generated themes are not allowed in the themes directory.
    RECOMMENDED: Text domain problems in library/widgets.php. You have not included a text domain!

    Line 83: <h3 style='margin-bottom:3px;'><?php _e('Theme Options'); ?></h3>

    RECOMMENDED: Text domain problems in library/admins.php. You have not included a text domain!

    Line 8: <h2><?php _e('WPMotors Options'); ?></h2>

    RECOMMENDED: Text domain problems in functions.php. You have not included a text domain!

    Line 462: $title = $previous ? __('Previous Post') : __('Next Post');

    INFO: Possible hard-coded links were found in the file header.php.

    Line 49: <div class='vic-flash-alt'><a href='http://www.adobe.com/go/getflashplayer'><img src='http://www.adobe.com/imag

    INFO: At least one hard coded date was found in the file library/shortcodes.php. Consider get_option( 'date_format' )

    General Observations:

    Overall: not-approved

    * Additional review may be required once the above issues are resolved.

    Again, this is not a complete review. The Theme may have other issues that do
    not meet the Theme Review Guidelines.

    * Theme Review - Theme_Review
    * Theme Unit Checklist - Theme_Unit_Test
    * Theme Development - Theme_Development

    Once the points above have been addressed appropriately using the available
    information found at the links above; please thoroughly review your theme and
    re-submit it using the uploader tool: http://wordpress.org/extend/themes/upload/
    ... this will generate a new Trac ticket.

    NB: Re-submitted Themes are given review priority over new Themes that have not
    been reviewed yet.

    Also note, to preserve your queue position if you upload a new revision to the
    theme before the current Trac ticket has been resolved:

    1. Note the "new" ticket number of the revision.
    2. Go to the oldest *open* ticket for your theme.
    3. Add a comment to the *open* ticket with a link to the "new" ticket.
    4. The next review should take this into consideration.

    Feel free to make use of the contact details below if you have any questions,
    comments, or feedback:

    * Leave a comment on this ticket
    * Send an email to the Theme Review email list
    * Use the #wordpress-themes IRC channel on Freenode

    Test Environment:
    WordPress Theme Reviews by pross

    * WordPress Version: 3.1
    * PHP version: 5.3.4
    * Multisite Enabled: No
    * Current User Role: administrator

  4. vicdesigns
    Member
    Posted 3 years ago #

    LMFAO. They also say "Send an email to the mailing list"
    Here's what I got back:

    You are not allowed to post to this mailing list, and your message has
    been automatically rejected. If you think that your messages are
    being rejected in error, contact the mailing list owner at
    theme-reviewers-owner@lists.wordpress.org.

    Bloody joke

  5. elfin
    Moderator
    Posted 3 years ago #

    Have you logged into Trac to leave a comment? (use the same credentials as you use on these forums).

    If that still doesn't work, you can sign up the the theme reviewers mailing list and speak to them there, see http://wordpress.org/extend/themes/contact/

  6. elfin
    Moderator
    Posted 3 years ago #

    you have to sign up to the mailing list first.

  7. vicdesigns
    Member
    Posted 3 years ago #

    Okay I will sign up. But they should bloody well tell people that.
    Honestly, I have always loved WordPress. But their so-called "Guidelines" are a complete and utter joke and a contradiction to their own rules.

  8. elfin
    Moderator
    Posted 3 years ago #

    I've just logged into Trac, and found your theme - provided you are logged in you can reply on that Trac ticket.

  9. vicdesigns
    Member
    Posted 3 years ago #

    I have just replied.
    Thanks.

  10. Simon Prosser
    Theme Review Admin
    Posted 3 years ago #

    I have answered your questions in the ticket, please feel free to join the mailing list.

  11. Simon Prosser
    Theme Review Admin
    Posted 3 years ago #

    LMFAO. They also say "Send an email to the mailing list"
    Here's what I got back:

    You are not allowed to post to this mailing list, and your message has
    been automatically rejected. If you think that your messages are
    being rejected in error, contact the mailing list owner at
    theme-reviewers-owner@lists.wordpress.org.

    Bloody joke

    vic, to quote the contact page:

    If you have questions or suggestions about the features at wordpress.org/extend/themes, join our mailing list to talk about it.

    The mailing list can be found at http://lists.wordpress.org/mailman/listinfo/theme-reviewers.

    If you follow the link it will take you to the list membership page. Our mailing list like 99% of mailing lists require you to sign up to avoid spam.

  12. Chip Bennett
    Theme Review Admin
    Posted 3 years ago #

    If I may attempt to clear up some misconceptions:

    1) Theme-Trac is not used in the same way as core Trac. Tickets are closed once the review is completed, as our workflow is such that we track reviews by the Open/Closed status. It's not a perfect workflow, but it's the best we have. We also understand that the Theme-Trac workflow is mostly unknown to anyone on the Theme Review team.

    Although a ticket is closed, in-ticket discussion can - and should, if the Theme author has questions - still take place.

    2) The Theme Reviewers mail list has moderated membership. It is an unfortunate, yet ubiquitous, requirement for mail lists. If not for membership moderation, the amount of spam we receive is simply untenable.

    3) The Theme in question is clearly and without a doubt Artiseer-generated. I suspected it when I glanced at the ticket some days back, and the reviewer confirmed it. He didn't duplicate the code here, but I will:

    From WPMotors Theme:

    // Not support old wp version
    if (WP_VERSION < 3.0) return;
    function vic_get_pages( $pages ) {
    	if(is_admin()) return $pages;
    
    	$excluded_option = get_option('vic_show_in_menu');
    	if (!$excluded_option || !is_array($excluded_option)) return $pages;
    	$excluded_ids = array();
    	foreach ($excluded_option as $id => $show)
    	{

    From Artiseer v3 Beta:

    // Not support old wp version
    if (WP_VERSION < 3.0) return;
    function art_get_pages( $pages ) {
    	if(is_admin()) return $pages;
    
    	$excluded_option = get_option('art_show_in_menu');
    	if (!$excluded_option || !is_array($excluded_option)) return $pages;
    	$excluded_ids = array();
    	foreach ($excluded_option as $id => $show)

    There are plenty of other signs of Artiseer.

    So, I am unsure why you have taken such great offense at the review comment indicating that the Theme is generated. Perhaps you misunderstood that by "generated", we include Artiseer-generated Themes.

    While there is nothing inherently wrong with using a tool such as Artiseer to generate WordPress Themes, such Themes are not appropriate for the Theme Repository. We are looking for Themes that represent original design work, to showcase the skill and creativity of the designer.

  13. vicdesigns
    Member
    Posted 3 years ago #

    You guys really have it bad hey?

    I used Artisteer to generate the core of the theme. If half of your designers were honest enough, they would also put their hands up and say "I do too", but their themes are accepted.
    Either way, forget it. I have better things to be doing besides arguing with you guys over a theme. It is obvious you will win the argument, which I still say your guidelines are a bit OTT to say the least.

    The whole idea of submitting themes is to allow other wordpress users to install them with ease and to use them for free under the GPL license as open source software. But I guess the Open Source and free usage is not your priority as an open source organization, is it? Nope, strict guidelines are what matters most here.

    Have a good day and remove my account from your system. I have no time to be wasting on those who do not respect people's contributions to open source.

  14. Chip Bennett
    Theme Review Admin
    Posted 3 years ago #

    With all due respect, I doubt you'll find a project that more values the GPL contributions of its community. That said: the purpose of the Repository is not to hold every conceivable Theme, GPL or not.

    To quote Matt Mullenweg himself:

    The goal of the theme directory is not to list every theme in the world, it's to list the best ones. We want a reasonable number of themes we can point to that embody the best and brightest of WordPress development, and that users can choose without compromise.

    I'm sorry that you take issue with the Guidelines. We have done our best to limit the scope to code quality, while leaving design and aesthetics up to the developer. We do, however, draw the line at generated Themes (including Artiseer-generated Themes).

    Having looked at well over 500 Themes in the past 6-8 months, I assure you that only a tiny fraction of Theme designers have attempted to submit Artiseer-generated Themes.

    For what it is worth: many, many Themes are derived from other Themes - the currently most prevalent being TwentyTen-derived Themes. We hold such Themes to a fairly high standard of demonstrating some significant design and/or functional distinction from TwentyTen before we approve them. (That standard will lessen significantly, should the Repository ever start accepting Child Themes.)

  15. vicdesigns
    Member
    Posted 3 years ago #

    Hi Chip.

    Completely understood. I do apologise for my frustration.
    I will start deriving from other themes to make it easier and resubmit.

    Thanks.

  16. Edward Caissie
    Theme Review Admin
    Posted 3 years ago #

    I will start deriving from other themes to make it easier and resubmit.

    I'm not sure if that should be taken as sarcasm or a gauntlet being thrown down but I look forward to your next submission of a new original design and theme concept. I'm sure it will be an interesting review process.

  17. elfin
    Moderator
    Posted 3 years ago #

    @Chip:

    2) The Theme Reviewers mail list has moderated membership. It is an unfortunate, yet ubiquitous, requirement for mail lists. If not for membership moderation, the amount of spam we receive is simply untenable.

    if that is the case, then you can't tell people to:

    * Send an email to the Theme Review email list

    as it is possible they won't be allowed to post to said list - can I suggest that be removed, and better instructions for replying Trac is given.

  18. vicdesigns
    Member
    Posted 3 years ago #

    I'm not sure if that should be taken as sarcasm or a gauntlet being thrown down

    I will quote Chip:

    many Themes are derived from other Themes - the currently most prevalent being TwentyTen-derived Themes. We hold such Themes to a fairly high standard of demonstrating some significant design and/or functional distinction from TwentyTen before we approve them.

Topic Closed

This topic has been closed to new replies.

About this Topic