WordPress.org

Ready to get started?Download WordPress

Forums

Theme My Login
[resolved] Tabindex added in 6.2 and removed in 6.2.3 (7 posts)

  1. Marco Cimmino
    Member
    Posted 1 year ago #

    Your users come to my plug-in to complain about your plug-in's issues, so while ago I sent you a patch to add tabindex to the registration form, you did on 6.2 and then removed on 6.2.3
    http://wordpress.org/support/topic/correct-tabindex?replies=2

    Can you please explain to your users why? The patch was useful to other plug-ins that adds correctly extra fields, I don't get it.

    http://wordpress.org/extend/plugins/theme-my-login/

  2. Chip_88
    Member
    Posted 1 year ago #

    Hey there!

    I also would like to know why you, Jeff Farthing, removed the patch contributed by Marco over a year ago.

    I tried to change the register-form.php by my own following the lines in Marco’s patch (see: http://wordpress.org/support/topic/correct-tabindex?replies=2).

    But it seems Theme My Login doesn’t accept this changes, i. e., fields added with CIMY - plugin are still skiped... :/

    Any further suggestions?!

    Thanks in advance & regards!

    Chipy

  3. Jeff Farthing
    Member
    Plugin Author

    Posted 1 year ago #

    Because browsers can handle tabindexing on their own. This is why I, Jeff Farthing, decided to remove tabindexes.

  4. Chip_88
    Member
    Posted 1 year ago #

    @ Jeff Farthing:
    I'm sorry, but you're NOT right at all.
    I tried different browsers (Opera, Firefox, Konqueror, ...), but it didn't handle tabindexing on their own in none of them.

    Inspirited by the lines of Marco Cimmino’s patch for the “Theme My Login” – Plugin, which he contributed over a year ago, I finally found the solution for the skipping “troubles”.

    Instructions:
    1. Open ~/wp-content/themes/[the_name_of_your_theme]/register-form.php .

    2. Change line 19 from:
    <input type="text" name="user_login" id="user_loginthe_instance(); ?>" class="input" value="the_posted_value( 'user_login' ); ?>" size="20" />

    → to:
    <input type="text" name="user_login" id="user_loginthe_instance(); ?>" class="input" value="the_posted_value( 'user_login' ); ?>" size="20" tabindex="10" />

    2. Change line 24 from:
    <input type="text" name="user_email" id="user_emailthe_instance(); ?>" class="input" value="the_posted_value( 'user_email' ); ?>" size="20" />

    → to:
    <input type="text" name="user_email" id="user_emailthe_instance(); ?>" class="input" value="the_posted_value( 'user_email' ); ?>" size="20" tabindex="10"

    3. Open ~/wp-content/plugins/theme-my-login/modules/custom-passwords/custom-passwords.php .

    4. Change line 31 from:
    <input autocomplete="off" name="pass1" id="pass1the_instance(); ?>" class="input" size="20" value="" type="password" />

    → to:
    <input autocomplete="off" name="pass1" id="pass1the_instance(); ?>" class="input" size="20" value="" type="password" tabindex="10" />

    5. Change line 32 from:
    <input autocomplete="off" name="pass2" id="pass2the_instance(); ?>" class="input" size="20" value="" type="password" />

    → to:
    <input autocomplete="off" name="pass2" id="pass2the_instance(); ?>" class="input" size="20" value="" type="password" tabindex="10" />

    As you can see, I added four times the SAME (NOT DIFFERENT!!!) tabindex (tabindex="10") for the first four fields.

    I am not sure, if it is the really right way, but anyway:
    Finally, it works as it should and as I want it to do!!!

    Now it’s possible to skip with the tabulator from one field to another in the right order and without any problems.

    I hope to help the community in sharing my solution with all of you.

    Regards from Germany!
    Chipy

    P.D.: So, Jeff, maybe you finally can change what a lot of the users, who are using your plugin together with the one of Marco for even more functionality, ask you to do!

  5. Jeff Farthing
    Member
    Plugin Author

    Posted 1 year ago #

    That is because the CIMY Extra Fields plugin is adding tabindexes. Go figure.

  6. Marco Cimmino
    Member
    Posted 1 year ago #

    That is because the CIMY Extra Fields plugin is adding tabindexes. Go figure.

    Jeff don't hide behind a finger, I can still see you.
    WordPress default registration form was adding tabindex till v3.4 too, I am not like an alien that was doing this all alone, come on.

    I just noticed now that they removed them together with WordPress 3.5, fine, I will remove them too.

    But don't point fingers like you heard something crazy while it is not.
    Anyway close this, no really point to establish a collaboration with you since you don't want to.

  7. Jeff Farthing
    Member
    Plugin Author

    Posted 1 year ago #

    I'm not sure I get what you're saying. I'm not hiding. I'm simply stating the facts. The whole nature of this post from the start was condescending toward me.

Topic Closed

This topic has been closed to new replies.

About this Plugin

About this Topic

Tags

No tags yet.