• Resolved WPSpeak

    (@devplus)


    Hi,

    Thanks for the great plugin.

    However, I’d like to give a suggestion to improve this plugin. I noticed that you’re using lots of inline CSS. If possible, please avoid doing this as this makes it harder to do CSS customization.

    Here’s an example of HTML markup from one of the themes I’m currently working on for a client of mine:

    https://gist.github.com/wpspeak/db2dc82514644ae5f879

    As you can see on line 7, the plugin added line-height: 10px to the markup and this cause a weird appearance on the theme. Because this is an inline CSS, it’s hard to alter it.

    Secondly, you also use inline css to customize the counter. Here’s the inline CSS you use:

    padding: 1px 1px 1px 1px; font-size: 70px; font-weight:bold; font-family: Helvetica Neue,Helvetica,Arial,sans-serif; color: #7fc04c; background-color: ; border: #ffffff solid 0px

    It’d great if all styling go into style.css file of your plugin instead of hardcoding it with inline CSS.

    I hope for the next release you could remove all inline CSS and put all CSS in style.css file only. This allows developers and designers to style the code easily and efficiently.

    https://wordpress.org/plugins/mashsharer/

Viewing 2 replies - 1 through 2 (of 2 total)
Viewing 2 replies - 1 through 2 (of 2 total)
  • The topic ‘Suggestion: Remove Inline CSS’ is closed to new replies.