WordPress.org

Ready to get started?Download WordPress

Forums

Ad King Pro
[resolved] Suggested improvements (6 posts)

  1. Iamhere
    Member
    Posted 12 months ago #

    Hey bud

    Just wanted to let you know that when using image output, there is no title or alt tags, which apart from SEO, means the code won't validate.

    Here's my suggested replacement

    Line 83 (approx) on includes/output.php

    if ($display_link)
    $output .= "";
    $output .= "<img src='".$image."' style='max-width: ".$term_meta['advert_width']."px; max-height: ".$term_meta['advert_height']."px;' alt='".get_the_title()."' />";

    http://wordpress.org/plugins/adkingpro/

  2. Ash Durham
    Member
    Plugin Author

    Posted 12 months ago #

    Hi Iamhere,

    That is a valid point my friend however your solution isn't going to work as you may think as the title when using the image output is the link of the advert ;)

    I will endeavor to add this option in the coming days. Keep an eye out.

  3. Iamhere
    Member
    Posted 12 months ago #

    Hi Ash

    Works for me ;-)

    Also you might want to consider limiting the admin thumbnail.
    Right now I am achieving that with this in my custom admin style, otherwise the image is too big

    /* adking pro images */
    tbody#the-list td.advert_image img
     {
    	max-width:150px !important;
    }
  4. Iamhere
    Member
    Posted 12 months ago #

    Also - looks like my original code didn't come out at the top;

    $output .= "<a href='".get_the_title()."' target='_blank' rel='".$post_id."'  title='click to visit'  >";
                            $output .= "<img src='".$image."' style='max-width: ".$term_meta['advert_width']."px; max-height: ".$term_meta['advert_height']."px;' alt='".get_the_title()."' />";
  5. Ash Durham
    Member
    Plugin Author

    Posted 12 months ago #

    Hi Iamhere,

    As you can see in your latest snippet of code, 'get_the_title()' is used for the href so I really wouldn't recommend using that for the alt tag of the image. I will provide a solid solution for this in the next update.

    Regarding the admin thumb, I see what you mean. I'll add some css on that in the next update also.

    Thanks

  6. Ash Durham
    Member
    Plugin Author

    Posted 11 months ago #

    Hi,

    Just letting you know, both the CSS and the option to have an alt tag have been added to version 1.9.0 that will be released in the coming hours.

    Thanks

Reply

You must log in to post.

About this Plugin

About this Topic