WordPress.org

Ready to get started?Download WordPress

Forums

Subscribe2
[resolved] Subscribe2 Improvements (6 posts)

  1. Milan Dinić
    Member
    Posted 2 years ago #

    I propose some changes for Subscribe2 and I prepared a patches for that.

    In this ticket I attached patches for two changes:

    • passing more arguments to s2_html_email hook
    • splitting subscribe_confirmation_sent message to separate messages for subscribing and unsubscribing since current message is very confusing for user (my English is not very good so MattyRob? should improve language in it)

    Additionally, here is translation of 7.0.1 in Serbian.

    http://wordpress.org/extend/plugins/subscribe2/

  2. mattyrob
    Member
    Plugin Author

    Posted 2 years ago #

    @Milan,

    Thanks for those tickets and translation files. First patch is quite sensible as it avoids needing to cut the message or subject from the string passed as they'd be available immediately.

    The second patch has issues though, it stops users of the plugin being able to edit the emails in the templates area of the Settings page. I've tried to minimise the number of templates by combining the subscribe and unsubscribe emails.

  3. Milan Dinić
    Member
    Posted 1 year ago #

    This ticket holds a patch that moves translation loading to init. More over there.

  4. mattyrob
    Member
    Plugin Author

    Posted 1 year ago #

    @Milan,

    Thanks for the patch, I've committed the spelling correction already and I'll read up on the translation patch later.

  5. mattyrob
    Member
    Plugin Author

    Posted 1 year ago #

    @Milan,

    According to the load_plugin_textdomain() codex entry, this function can be called more than one on a single domain and the strings are merged.

    In the new load_translations() function how about something like this:

    load_plugin_textdomain('subscribe2', false, S2DIR);
    load_plugin_textdomain('subscribe2', false, S2DIR . "languages/");
    load_plugin_textdomain('subscribe2', false, WP_CONTENT_DIR . "/languages/subscribe2/");

    That way the plugin looks in it's own root, in a languages folder and in the core location too.

  6. mattyrob
    Member
    Plugin Author

    Posted 1 year ago #

    In fact that last core location check might be better like this:
    load_plugin_textdomain('subscribe2', false, WP_LANG_DIR . "/");
    Then the code will look in wp-content (or whatever it might be names) and wp-includes for a languages folder.

Topic Closed

This topic has been closed to new replies.

About this Plugin

About this Topic

Tags