Another little issue regarding the localization:
find line 45 in settings/interface/meta.php:
'description' => __( 'Adds a tab to the container. Not available in widgets.' )
should be
'description' => __( 'Adds a tab to the container. Not available in widgets.', 'uf' )
So the localized string could displayed properly 😉
While talking about localization: Check your uf-bg_BG.po file for the source pathes: It reads ‘/Users/radoslavgeorgiev/Sites/fields/playground/wp-content/plugins/ultimate-fields’, where ‘../’ would be the better choice 😉
Tomorrow I finish the german translation, simply drop me a line where to sent the .po & .mo.
Same Problem in classes/UF_Field_Separator.php on lines 24 and 28. Another issue here: It seems that the labels on the left side are generated from the id. You missed the third parameter and mixed up the set_description method of UF_Field::factory. So here is the complete correct function:
static public function settings_fields( $field_type ) {
$fields = array(
UF_Field::factory( 'text', 'title', __( 'Title', 'uf' ) )
->multilingual()
->set_description( __( 'This title will separate different kinds of content.', 'uf' ) )
->make_required(),
UF_Field::factory( 'text', 'description', __( 'Description', 'uf' ) )
->multilingual()
->set_description( __( 'This text will appear under the title and may be used to give users directions what to do.', 'uf' ) )
);
return apply_filters( 'uf_field_settings_fields', $fields, $field_type );
}
Hi again sixtyseven,
- WordPress was hijacking some clicks and although it seems that the down arrow was not working, it was working twice: first open and then close. Not it’s okay.
- This is fixed too.
- This is interesting. I did a few tests:
edit.php?post_type=page => OK. The page appeared in the Pages submenu.
admin.php?page=all-fields => NOT OK. The page is not there.
all-fields => OK. The page appeared under another Ultimate Fields page.
edit.php?post_type=ultimatefields => OK. The page appeared in the Ultimate Fields submenu.
options-general.php => OK. The page appeared in the Setting submenu.
Seems like if the page is a custom one and resides under admin.php?page=xxxx then only xxxx is needed, as it is the page’s slug. If it is another one, it’s full URL is needed.
The localization issues are fixed – I changed the path in bg_BG, added both titles and the textdomain.
You can check the development version by clicking the last link at http://wordpress.org/plugins/ultimate-fields/developers/ . If everything so far seems okay to you, please mark the thread as resolved and start a new one if (most probably when) needed.
You can mail me the po/mo file(s) at rageorgiev[at]gmail.com
Thank you.
Hi again Rado,
unfortunately not all issues are fully fixed right now, we are only halfway there. First to the localization, as it seems the simplest problem: Again, check your uf-bg_BG.po file for the source pathes: It still shows ‘/Users/radoslavgeorgiev/Sites/fields/playground/wp-content/plugins/ultimate-fields’. This is more or less a cosmetical problem, but since it is the only language file you are offering, people like me probably copy and use them for their own translation. Speaking of this: I’ll send you the german translation right after finishing this post.
On to the UF_Field_Separator.php: You fixed the labels, but left out the descriptions. Line 24 should be
->set_description( __( 'This title will separate different kinds of content.', 'uf' ) )
analogue line 28 should be
->set_description( __( 'This text will appear under the title and may be used to give users directions what to do.', 'uf' ) )
Now to the placing of the options pages: Halfway done, too. Let us assume the following: I created three containers, each of it with a slug like container1, container2, container3. When I place container1 in the main menu, I now could place container2 and container3 as sub menu items of container1. But still the url of the first placed container1 is changed to whatever is placed next under it, i.e. yourdomain.com/wp-admin/container2.
And the most important Problem still exists: The Urls in such a case are invalid! yourdomain.com/wp-admin/container2 for example should be yourdomain.com/wp-admin/admin.php?page=container2
When I now open this link from the browser bar (ONLY when placed under another Ultimate Fields page), I get a message that I do not have the privileges to view the page.
Additionally, when I place the page under another page named with slug, a 404 error occurs. I tried change the page slug to a full link like admin.php?page=container1, but in this case, the options page appears nowhere.
I’d like to thank you for your fantastic work so far!
For the invalid Urls, could this probably have something to do with different permalink structure? Just an idea …
Thank you for the translations! I’m extremely happy that you seem to like the plugin that much and that you spent the time to do this 🙂
Your translations is added to the plugin (dev version). Also, I couldn’t get to a point where the X-Poedit-Basepath and X-Poedit-SearchPath-0 were right. I used the same ones as your .po file and everything should be okay.
Now for the option pages: Something I seem not to have thinked about was the priority of page registration and admin_menu hooks. When I was testing this I was always creating the parent page first, as it had to be already there for the menu. Because of that, later it gets registered first and everything is okay. Now that I knew that there seems to be another error, I played with it more and realized what’s what. Now the issue should be finally solved!
I’m commiting it as a dev version in a couple of minutes.
Downloaded and installed the dev version, all works well now, the big trouble with placing the options pages and the resulting page permissions is gone 😉
Seems that the free version of the plugin is now ready for release (even if I didn’t find the german language files in the download *lol*). Can’t wait to get my hands on the pro version.
To answer your question: Yes, I like your plugin that much, it could be a real game changer!!! And I am glad that I could be a little part of it. Could you probably tell a release date of the pro version? And when will you finally open the homepage? I eagerly wait for instructions to implement UF in my own plugins 😉 If I can help out with anything, let me know. I allready have a plethora of ideas for new fields and am quite sure that I can come up with something nice as an addition …
I can’t stress it enough: Top Notch Author support given! Thank you