WordPress.org

Ready to get started?Download WordPress

Forums

Sandbox 1.6 for WordPress 2.7+ (8 posts)

  1. Dreamcolor
    Member
    Posted 5 years ago #

    I already modified it can use the new things of WordPress 2.7.

    For example Threading Comments & Comments Paging & Stick Post ......

    If you like it. You can download it here.

    I'm sorry about my poor english. So I didn't write a english description. But you can simple click the link to download it.

    PS: I didn't included any languages pack. So you should make it by yourseves base the old po files.

    PS2: I didn't fix any bug. I just make it can use under WP2.7. And there maybe some new bugs out. Who can test?

  2. eminentstyle
    Member
    Posted 5 years ago #

    @Dreamcolor, thanks very much. Does exactly what it says on the tin :-)

  3. Peter Wilson
    Member
    Posted 5 years ago #

    Here's how Google translates @Dreamcolor's page into english.

    Thanks for the update, Dreamcolor.

  4. monodistortion
    Member
    Posted 5 years ago #

    Hi Dreamcolor,

    I was updating my theme and I was looking at your code in comments.php.

    On this page:
    http://codex.wordpress.org/Migrating_Plugins_and_Themes_to_2.7/Enhanced_Comment_Display

    it says you should remove the section:
    <input type="hidden" name="comment_post_ID" value="<?php echo $id ?>" />

    because it is replaced by the new function:
    <?php comment_id_fields(); ?>

  5. eminentstyle
    Member
    Posted 5 years ago #

    @monodistortion

    For the benefit of the community, can you update Dreamcolor's fix and release here? Thanks.

  6. monodistortion
    Member
    Posted 5 years ago #

    I just tried out this theme and that small bug doesn't really affect things. It just gives you two hidden inputs with the same value.

    One thing I noticed is that the custom callback function sandbox_comments doesn't quite format the nested comments the same as the default function so when you press the "reply" link the form doesn't move right below the "reply" link. It looks like there needs to be one more <div> within each <li> so that the form knows to move below that <div>.

  7. monodistortion
    Member
    Posted 5 years ago #

    Hmm, this is completely unrelated but now I see that comments.php is also missing the line:
    <?php do_action('comment_form', $post->ID); ?>
    which is used to as a plugin API hook.
    http://codex.wordpress.org/Theme_Development#Plugin_API_Hooks

    This was in Sandbox before so maybe Dreamcolor took it out by mistake instead of taking out:
    <input type="hidden" name="comment_post_ID" value="<?php echo $id ?>" />

  8. monodistortion
    Member
    Posted 5 years ago #

    Ok, after a few hours of combing through the core WordPress comment-template.php code and comparing it to Dreamcolor's Sandbox update I think I figured out all the problems with the threaded comments. The Codex documentation isn't very complete so I'll have to try improving it when I have more time.

    When you click on the "reply" link the comment form should move directly below that comment like in the default (e.g. Kubrick) comment display.

    Note that if you change the argument 'style' => 'div' or 'style' => 'ol' the comment form moves to the end of that comment chain. I'm not sure why but this is how the default comment threading works.

    Here are the two updated files, comments.php and functions.php:
    http://noisychaos.com/external/wp-work/sandboxv16comments2009-02-27.zip

    I haven't tested pings since this has just been on my local machine.

Topic Closed

This topic has been closed to new replies.

About this Topic