WordPress.org

Ready to get started?Download WordPress

Forums

RSS feed suggestion (4 posts)

  1. cardmagic
    Member
    Posted 9 years ago #

    Why in god's name do you guys do:

    } elseif ($encode_html == 2) {
    $output = strip_tags($output);
    $output = str_replace('&', '&', $output);
    }

    Instead of

    } elseif ($encode_html == 2) {
    $output = htmlentities($output);
    }

    in the function the_excerpt_rss from wp-includes/template-functions-post.php

    There are a lot of very good reasons to use htmlentities... especially for cases where < and > show up outside of a tag context and need to be converted to &lt; and &gt;, but for other good reasons too. If I could figure out where to send a patch to the project, I would have.

  2. cardmagic
    Member
    Posted 9 years ago #

    Ah, I see. You are doing it that way to make the word counting easier. You must admit that this is a hack and figure out a better way to do it.

  3. NuclearMoose
    Member
    Posted 9 years ago #

    The bug base is at mosquito.wordpress.org and please feel free to check it and if it has not already been logged, then do submit it.

    There is also a hackers' mailing list which you are welcome to join and post your comments and suggestions. See this page for information: http://wordpress.org/mailman/listinfo/

    Also, it would be good to mention the WordPress version you suggest this change for. If it is for a BETA version (V1.5) then please use the BETA DISCUSSION forum in the future.

    Thank you for your help.

    EDIT: It never hurts to use some tact when you post your ideas and suggestions either. There is a very good set of code developers on this project and a very good crew of contributing coders. Nothing gets done without discussion and at times, debate. You would do well to get better informed before making snap judgements about things being "hacks" when you haven't done any research to discover why things are done a certain way.

  4. Ryan Boren
    WordPress Dev
    Posted 9 years ago #

    htmlentities is very i18n unfriendly.

Topic Closed

This topic has been closed to new replies.

About this Topic

Tags

No tags yet.