Hi,
If someone could review my theme, that would be great!
Demo here: http://totum5.codebotics.co.uk/
Thanks in advance!
Toby
Review my Site/Theme (20 posts)
-
CodeBotics
Posted 8 months ago #
-
Andrew Nevins
Posted 8 months ago #
Validate your website.
-
chomachomachoma
Posted 7 months ago #
Nobody gives a crap if your site validates or not. Especially considering it is almost impossible to validate when using css3 properties as you are. Maybe it's important where Andrew works that his code validates, but in the real-world it's usually not of any concern.
- Looks good. I like the simple design.
- Loads slowly. I assume this is on shared hosting which will explain the lag when loading. Sometimes times out without loading entire page.
- "Comments RSS" link in footer goes to broken/missing page
- I like the use of shortcodes
- Good job on making it device responsive. All sites built nowadays should be doing this.
Overall, I think it's a nice clean responsive design. Good work.
-
Posted 7 months ago #
Please don't take this as an excuse to argue; but in the real world websites need to be browser-compatible to reach realistic audiences and conforming to W3C's standards helps achieve this.
-
FredrixDesign
Posted 7 months ago #
Validation is important.
-
Posted 7 months ago #
I thought the post was to critique the website in question, not argue about code validation.
Fact of the matter is 100% of users and 99% of web developers don't care if the code if valid. Only thing that actually matters and people care about is that the pages display correctly. Only anal-retentive programmers that think they are superior believe that CSS and HTML needs to validate. It just simply is not important in most cases and most anybody that knows what they are talking about will agree it's a waste of time.
Seriously, when was the last time you left a site because the code didn't validate? You kidding me?
-
Posted 7 months ago #
Nevins - If it's so important, then why do none of your sites validate? Do you not practice what you preach?
[Links moderated. There was no need for that] -
Posted 7 months ago #
Please don't take this as an excuse to argue
-
Jan Dembowski
Posted 7 months ago #
*Blows whistle and makes the time out sign*
@CodeBotics Nice site and layout. Constructively you may want to address some of those validation issues. Or not, your call. ;)
-
Posted 7 months ago #
Thanks for your feedback everyone.
I will validate where possible, although it's not always possible. Using my site as an example, webkitallowfullscreen and all the other allowfullscreen's are part of the embed code copied directly from Vimeo. This stuff isn't hard coded into the theme, and if it's a problem I'm sure Vimeo wouldn't still be adding it to it's own embed code.
As for the rest, I should have used classes instead of ID's and I will fix that now.
@chomachomachoma thank you for the specific feedback, yes I am currently using a shared host unfortunately. This might be sorted in the future. The comments feed wasn't working as there were no comments, I've added a comment now to fix that! I might add an if statement to hide the comments link if there are no comments as a better fix though.
Thanks again everyone, and feel free to check the validator in a few minutes time!
-
Posted 7 months ago #
Also, regarding the duplicate ID's surrounding the WP calendar widget - for now I'll just remove one of the widgets from my home page, as it's WP generated code.
-
Posted 7 months ago #
-
Posted 7 months ago #
Yes but do check whether browser issues are now resolved (if you haven't already).
http://www.browserstack.com/ -
Posted 7 months ago #
I don't have browser stack, but I've tested it on the major browsers. Haven't tested below IE8.
-
imho, in this case, pointing out validation errors was correct and important, as the review was about a (new?) theme, not just a site.
re older browsers - the menu drops behind the slide and is unusable in IE7;
in FF16, when narrowing the browser, there is some 10-20% extra horizontal scrollbar space.
is the theme licensed under GPL?
-
Posted 7 months ago #
I agree, it is important. And yep, new theme.
Do you think it's worth trying to fix the IE7 issue? Surely a line has to be draw somewhere with IE, but where?
Thanks for pointing that out, there's a little scrolling in Chrome as well, but nowhere near as much as in FF. I'll look into fixing that shortly.
The PHP files are licensed under GPL, as required. Everything else will be licensed under a single use license.
Thanks for your comments.
-
Posted 7 months ago #
Fixed that issue now, thank you. I haven't yet fixed the IE7 issue however.
-
aliceralph
Posted 7 months ago #
I disagree that validation is unnecessary. In my experience - if you are having browser compatibility issues, I find that doing thorough validation solves almost all problems, leaving you with just a few tweaks here and there. I'm not saying the validation is a priority over everything else, I just think a lot of problems stem from invalid code.
-
smartmobilesigns
Posted 7 months ago #
it will fixed on IE8 better to move their HTML.
-
Looks nice, but it takes a bit to load.
You would definitely need to re-compress your front-page splash images.
Otherwise, I don't find any fault with it.
Keep it up :)
Reply
You must log in to post.
