WordPress.org

Ready to get started?Download WordPress

Forums

[closed] Remove Revisions Easter Egg. (10 posts)

  1. ianatkins
    Member
    Posted 3 years ago #

    On the edit post / page screen if you compare two revisions, which are the same you get presented with a black screen and a message about infinite loops.

    Obviously comparing the same revision to itself is pointless, but this 'humorous' Easter egg wasn't so funny for my panicked, non-technical client.

    Given the clarity of thought on the rest of the WordPress UI this was a little disappointing to discover.

    Anyone else like to see this removed?

    To see the easter egg in action:
    http://ocaoimh.ie/wordpress-26-easter-egg/

  2. Yeah, but I doubt they'll make that mistake again ;)

    Submit a request in trac, however. I doubt it'll be removed, though, since a lot of people find it amusing.

  3. ianatkins
    Member
    Posted 3 years ago #

    Well if it was an error message, rather than something that looked like a virus, then perhaps they wouldn't make the mistake again. As it stood they had no idea they had made a mistake.

    Obviously a more intuitive approach would to simply not let you select a comparison on the same version.

    Humour has its place, if its inclusive ;)

    I'll see what the feedback is like here, if people agree I'll pop something on trac.

  4. elfin
    Moderator
    Posted 3 years ago #

    I think it should stay, but perhaps its time to add a hook to allow those that want to change it.

  5. Eric Mann
    Member
    Posted 3 years ago #

    @ianatkins - I ran into the same problem with a client. I took some time to write a quick patch to prevent this from happening with my needier clients in the future:

    function prevent_matrix_easter_egg() {
        $left = empty( $_POST['left'] ) ? ( empty( $_GET['left'] ) ? '' : $_GET['left'] ) : $_POST['left'];
        $right = empty( $_POST['right'] ) ? ( empty( $_GET['right'] ) ? '' : $_GET['right'] ) : $_POST['right'];
    
        if($left == $right) {
            $redirect = get_edit_post_link( $left );
            wp_die("Error: Cannot compare a revision to itself.<br /><a href=\"" . $redirect . "\">Go Back</a>");
        }
    }
    add_action('admin_action_diff', 'prevent_matrix_easter_egg');

    This will override the Matrix message and instead present a standard WordPress "you can't do that" error. It might not be the best way to do it, but it works for now. In the mean time, I'm running a quick contest on WordPress Answers to see if anyone can come up with a more elegant solution.

  6. ianatkins
    Member
    Posted 3 years ago #

    Wow nice one Eric, thanks for sharing.

    I guess the more elegant solution would be the removal from core!

    Thanks again.

  7. unrulyguides
    Member
    Posted 3 years ago #

    I agree with removing it - especially since most users are "not" techno savvy and use blogs as a business. I was at first shocked to find it. Even with the "Go Back" - I still wasn't sure if my blog had been hacked or not - and I am sure my clients would be calling me day and night -- It looked like a virus. There should be an option to remove.

  8. This will be addressed in a future release.

    http://core.trac.wordpress.org/ticket/12816

  9. RavanH
    Member
    Posted 3 years ago #

    +1 for removing it... at least for sub-sites in a multi-site network setup where it is likely to cause some panick :)

    in the mean time, the winner of Eric Mann's contest on http://wordpress.stackexchange.com/questions/3253/coding-challenge-javascript-easter-egg/ is a pretty easy work-around when thrown in /mu-plugins/

  10. PuNK DeSi
    Member
    Posted 3 years ago #

    +1
    there should be option to turn off Revision & Draft feature
    at least those who dnt want this can turn it off

Topic Closed

This topic has been closed to new replies.

About this Topic