Viewing 7 replies - 1 through 7 (of 7 total)
  • Hi Dan, yes you are correct about loosing your css modifications.

    One way to keep your css modifications even if you upgrade the plugin is to use a child theme.

    I just thought I would share that with you.

    Kind regards

    Plugin Author davidhme

    (@davidhme)

    Dan,

    Ooops, seems like some cowboy code made its way into the plugin. I’ll try to clean this up in one of the next updates.

    Thank you,
    David

    Thread Starter Daniel Schutzsmith

    (@schutzsmith)

    Thanks David! BTW, here’s what we made with the Easy Pricing Tables! http://awesomecause.com/pricing/

    Cheers,
    dan

    Plugin Author davidhme

    (@davidhme)

    Dan,

    Looks great!

    I just had a quick look at my use of !important. The reason we’ve introduced them in the first place is that lots of themes have !important statements all over the place.

    I agree with you that using !important isn’t ideal, but removing these statements might cause Easy Pricing Tables to break on dozens of sites that are currently running it.

    I’ll have another look at this, but I can’t guarantee that I’ll actually be removing any !important statements.

    Supporting a CSS-heavy plugin like this can be a bit of a challenge at times. =)

    David

    Thread Starter Daniel Schutzsmith

    (@schutzsmith)

    Not the biggest of worries. I just know that with Headway Themes, for some reason your !important overrides any styles we apply.

    We can just keep striping out the !importants, but in general, its best practice to not have !importants in plugins.

    FWIW, from what I’ve personally seen in your css, the !importants seem to be on classes that would be unique to your plugin, not widely used wordpress core classes, so you should be OK.

    Cheers either way!

    Plugin Author davidhme

    (@davidhme)

    Thanks, I appreciate your suggestion. I’ll take another look at the CSS.

    Plugin Author davidhme

    (@davidhme)

    I’ve cleaned up the HTML & CSS a bit more with the latest release and removed some !importants.

Viewing 7 replies - 1 through 7 (of 7 total)
  • The topic ‘Remove !important’ is closed to new replies.