WordPress.org

Ready to get started?Download WordPress

Forums

Pardot
[resolved] RegEx inserting class to closing iframe tag (5 posts)

  1. Sith Lord Goz
    Member
    Posted 1 year ago #

    Hi - looks like the shortcode regex is accidentally inserting the standard class (pardotform) to the closing tag as well as the opening tag:

    <iframe class="pardotform" .....></iframe class="pardotform">

    http://wordpress.org/extend/plugins/pardot/

  2. Cliff Seal
    Member
    Plugin Author

    Posted 1 year ago #

    Good catch—I'll patch that up shortly. Is it causing you any issues, currently?

  3. Cliff Seal
    Member
    Plugin Author

    Posted 1 year ago #

    I've pushed an update (1.3.5), and it should be live shortly. Please update, click 'Clear Cache' in Settings > Pardot Settings, and that should patch you up! Please let me know if you have any further issues, and I'll reopen this and address them.

    Thanks again! You'll see a thank you message in the update notice. :)

  4. Sith Lord Goz
    Member
    Posted 1 year ago #

    Nice! Confirmed fix works and hats-off for such a quick turnaround. Also, thanks for the credit :)

    While I have your attention... could I put in a feature request?! :P

    It would be great if you could expose the id and name attributes of the generated <iframe> in the shortcode: - that would make it easier (and more specific) to manipulate them with jQuery etc.

    IE (of course) doesn't like frames that have no identifier, and it makes enumerating the window.frames collection a pain... I've worked around it, but thought it would be nice to have.

    (I'm working to make a dynamic iframe that can resize its height to fit its contents, so that we don't have ugly scrollbars in our sidebars & pages!)

    Thanks!

  5. Cliff Seal
    Member
    Plugin Author

    Posted 1 year ago #

    I haven't heard of anyone having trouble with that before, but the plugin uses the minimalist code generated directly from Pardot, and we only append classes to assist folks in matching their theme. In your case, you might be better off using an iframe shortcode or something of the like to suit your needs.

    Feel free to email me at cliff dot seal at pardot dot com if you'd like some personalized assistance or pointers.

Topic Closed

This topic has been closed to new replies.

About this Plugin

About this Topic