WordPress.org

Ready to get started?Download WordPress

Forums

eShop
[resolved] Proceed to Checkout Button issue (9 posts)

  1. useStrict
    Member
    Posted 1 year ago #

    Some third-party plugins call do_shortcode() on their own, which causes the "Proceed to Checkout" Button to go missing on the final rendering of the checkout page ("confirm your details"). The solution was to deactivate those pesky third-party plugins, like Facebook Image, but now this is being caused by Jetpack and Newsletter plugins as well.

    I had a look at the code and it's because the "Proceed to Checkout" button is added with an include_once() call. It gets included on the first call to do_shortcode(), but not on the subsequent calls.

    Please help, as I cannot afford to deactivate Jetpack and Newsletter!

    Thanks,
    Vinny

    http://wordpress.org/extend/plugins/eshop/

  2. useStrict
    Member
    Posted 1 year ago #

    Here's the diff for my change.


    wp-content/plugins/eshop/checkout.php
    ===================================
    960c960
    < include_once($eshopmgincpath);
    ---
    > include($eshopmgincpath);
    1095c1095

  3. esmi
    Forum Moderator
    Posted 1 year ago #

    Thank for that. We are hoping to work in eShop to tackle this over the weekend.

  4. elfin
    Moderator
    Plugin Author

    Posted 1 year ago #

    that is weird... Obviously I'll need to test that it doesn't cause errors - but hopefully I can add it into the next release. I might not get to it this weekend though.

  5. useStrict
    Member
    Posted 1 year ago #

    I just noticed why I did not apply it in the past - it does have a downside. Two orders are created in the system, and while one of them gets processed, the other is left in "Pending" state.

    Still, it's a valid workaround - better to have an extra (Pending) order than to have no order at all :)

    I'm sure you'll find a better solution for this soon.

  6. elfin
    Moderator
    Plugin Author

    Posted 1 year ago #

    ahh yeah, that isn't a solution then. But it does confirm what i thought it was, and I should still be able to correct it. It's a long overdue issue within eShop that needs amending (if it is indeed the issue I think it is)

  7. elfin
    Moderator
    Plugin Author

    Posted 1 year ago #

    Ok a fix is going in, but I am not 100% sure it will be suitable. To correctly remove this I would need a hefty rewrite of large portions of the plugin. Time for that project is unlikely to be found in the near future.

  8. useStrict
    Member
    Posted 1 year ago #

    Thanks elfin. It's working perfectly now.

  9. elfin
    Moderator
    Plugin Author

    Posted 1 year ago #

    had to remove that fix - it didn't work well at all.

    Please see http://quirm.net/forum/topic.php?id=17238 though, as I need testers for a fix that should resolve this correctly.

Topic Closed

This topic has been closed to new replies.

About this Plugin

About this Topic