WordPress.org

Ready to get started?Download WordPress

Forums

[resolved] Portrait images messes gallery layout (13 posts)

  1. mooread123
    Member
    Posted 2 years ago #

    hey
    this is my first call for help. I'm having trouble with sorting out [gallery] coding. http://aidenmoore.co.uk/photography/places/ when i add portrait images to the gallery the whole layout messes up and doesn't stick to the three column default that it should be. any help would be great!

    Thanks

  2. theotherlebowski
    Member
    Posted 2 years ago #

    if i were you i'd set each image to a square ration thumbnail size so that your grid stays the same. let the lightbox handle the landscape/portrait stuff.

  3. mooread123
    Member
    Posted 2 years ago #

    thanks for the response
    just did it there quickly size="thumbnail" and they images are still being mucked about the place and not sticking to any grid

    cheers

  4. theotherlebowski
    Member
    Posted 2 years ago #

    are you using the gallery shortcode? if so, specify the number of colums as 4 maybe and see if that helps :)

  5. mooread123
    Member
    Posted 2 years ago #

    i also tried changing the size of the thumbnail in the settings - media to 450x450

  6. mooread123
    Member
    Posted 2 years ago #

    tried that and not any better. this is the shortcode im using [gallery link="file" size="thumbnail" columns="4"] You can click the link in the original post to see whats going on now. :(

  7. theotherlebowski
    Member
    Posted 2 years ago #

    ok, i think i've solved it but i'm not too sure how you're going to do it...

    i found this in between every three images in the code:

    <br style="clear: both">

    after i removed it in chrome's web developer viewer things started to line up better.

    then i found this:

    .gallery dl  + dl {
    margin-left: 30px;
    }

    i'm pretty sure that's not valid css so i removed the + dl and it all fell into place. it's in screen.css at line 987. try just removing that and see what happens and i'll try to figure out where you'll need to remove the line break...

  8. theotherlebowski
    Member
    Posted 2 years ago #

    ok, it would seem that you need to edit the media.php file in the wordpress core (when you upgrade this will revert back to normal again so keep this handy if it works!)

    in media.php look for this line of code:

    $output .= "</{$itemtag}>";
    		if ( $columns > 0 && ++$i % $columns == 0 )
    			$output .= '<br style="clear: both" />';
    	}
    
    	$output .= "
    			<br style='clear: both;' />
    		</div>\n";
    
    	return $output;
    }

    you need to edit out the bold bit in the second instance of

    $output .= "
    <strong><br style='clear: both;' /></strong>
    </div>\n";

    if that doesn't do it then try editing out the first!

  9. theotherlebowski
    Member
    Posted 2 years ago #

    any joy?

  10. mooread123
    Member
    Posted 2 years ago #

    im looking at media.php but can't see the code in it. this is what i have `<?php
    /**
    * Media management action handler.
    *
    * @package WordPress
    * @subpackage Administration
    */

    /** Load WordPress Administration Bootstrap */
    require_once('./admin.php');

    $parent_file = 'upload.php';
    $submenu_file = 'upload.php';

    wp_reset_vars(array('action'));

    switch( $action ) :
    case 'editattachment' :
    $attachment_id = (int) $_POST['attachment_id'];
    check_admin_referer('media-form');

    if ( !current_user_can('edit_post', $attachment_id) )
    wp_die ( __('You are not allowed to edit this attachment.') );

    $errors = media_upload_form_handler();

    if ( empty($errors) ) {
    $location = 'media.php';
    if ( $referer = wp_get_original_referer() ) {
    if ( false !== strpos($referer, 'upload.php') || ( url_to_postid($referer) == $attachment_id ) )
    $location = $referer;
    }
    if ( false !== strpos($location, 'upload.php') ) {
    $location = remove_query_arg('message', $location);
    $location = add_query_arg('posted', $attachment_id, $location);
    } elseif ( false !== strpos($location, 'media.php') ) {
    $location = add_query_arg('message', 'updated', $location);
    }
    wp_redirect($location);
    exit;
    }

    // no break
    case 'edit' :
    $title = __('Edit Media');

    if ( empty($errors) )
    $errors = null;

    if ( empty( $_GET['attachment_id'] ) ) {
    wp_redirect( admin_url('upload.php') );
    exit();
    }
    $att_id = (int) $_GET['attachment_id'];

    if ( !current_user_can('edit_post', $att_id) )
    wp_die ( __('You are not allowed to edit this attachment.') );

    $att = get_post($att_id);

    if ( empty($att->ID) ) wp_die( __('You attempted to edit an attachment that doesn’t exist. Perhaps it was deleted?') );
    if ( 'attachment' !== $att->post_type ) wp_die( __('You attempted to edit an item that isn’t an attachment. Please go back and try again.') );
    if ( $att->post_status == 'trash' ) wp_die( __('You can’t edit this attachment because it is in the Trash. Please move it out of the Trash and try again.') );

    add_filter('attachment_fields_to_edit', 'media_single_attachment_fields_to_edit', 10, 2);

    wp_enqueue_script( 'wp-ajax-response' );
    wp_enqueue_script('image-edit');
    wp_enqueue_style('imgareaselect');

    get_current_screen()->add_help_tab( array(
    'id' => 'overview',
    'title' => __('Overview'),
    'content' =>
    '<p>' . __('This screen allows you to edit five fields for metadata in a file within the media library.') . '</p>' .
    '<p>' . __('For images only, you can click on Edit Image under the thumbnail to expand out an inline image editor with icons for cropping, rotating, or flipping the image as well as for undoing and redoing. The boxes on the right give you more options for scaling the image, for cropping it, and for cropping the thumbnail in a different way than you crop the original image. You can click on Help in those boxes to get more information.') . '</p>' .
    '<p>' . __('Note that you crop the image by clicking on it (the Crop icon is already selected) and dragging the cropping frame to select the desired part. Then click Save to retain the cropping.') . '</p>' .
    '<p>' . __('Remember to click Update Media to save metadata entered or changed.') . '</p>'
    ) );

    get_current_screen()->set_help_sidebar(
    '<p><strong>' . __('For more information:') . '</strong></p>' .
    '<p>' . __('<a href="http://codex.wordpress.org/Media_Add_New_Screen#Edit_Media" target="_blank">Documentation on Edit Media</a>') . '</p>' .
    '<p>' . __('<a href="http://wordpress.org/support/" target="_blank">Support Forums</a>') . '</p>'
    );

    require( './admin-header.php' );

    $parent_file = 'upload.php';
    $message = '';
    $class = '';
    if ( isset($_GET['message']) ) {
    switch ( $_GET['message'] ) :
    case 'updated' :
    $message = __('Media attachment updated.');
    $class = 'updated';
    break;
    endswitch;
    }
    if ( $message )
    echo "<div id='message' class='$class'><p>$message</p></div>\n";

    ?>

    <div class="wrap">
    <?php screen_icon(); ?>
    <h2>
    <?php
    echo esc_html( $title );
    if ( current_user_can( 'upload_files' ) ) { ?>
    <a href="media-new.php" class="add-new-h2"><?php echo esc_html_x('Add New', 'file'); ?></a>
    <?php } ?>
    </h2>

    <form method="post" action="" class="media-upload-form" id="media-single-form">
    <p class="submit" style="padding-bottom: 0;">
    <?php submit_button( __( 'Update Media' ), 'primary', 'save', false ); ?>
    </p>

    <div class="media-single">
    <div id='media-item-<?php echo $att_id; ?>' class='media-item'>
    <?php echo get_media_item( $att_id, array( 'toggle' => false, 'send' => false, 'delete' => false, 'show_title' => false, 'errors' => !empty($errors[$att_id]) ? $errors[$att_id] : null ) ); ?>
    </div>
    </div>

    <?php submit_button( __( 'Update Media' ), 'primary', 'save' ); ?>
    <input type="hidden" name="post_id" id="post_id" value="<?php echo isset($post_id) ? esc_attr($post_id) : ''; ?>" />
    <input type="hidden" name="attachment_id" id="attachment_id" value="<?php echo esc_attr($att_id); ?>" />
    <input type="hidden" name="action" value="editattachment" />
    <?php wp_original_referer_field(true, 'previous'); ?>
    <?php wp_nonce_field('media-form'); ?>

    </form>

    </div>

    <?php

    require( './admin-footer.php' );

    exit;

    default:
    wp_redirect( admin_url('upload.php') );
    exit;

    endswitch;
    `

  11. theotherlebowski
    Member
    Posted 2 years ago #

    wrong media.php file, that's the admin one. it's in wp-includes folder.

  12. mooread123
    Member
    Posted 2 years ago #

    Think that should be it now! thanks for the help. I'll just need to stick to the thumbnails.
    Thanks!!

  13. theotherlebowski
    Member
    Posted 2 years ago #

    no worries, i'll check the site in a bit to see how it looks :D nice photo's by the way

Topic Closed

This topic has been closed to new replies.

About this Topic