WordPress.org

Ready to get started?Download WordPress

Forums

WP RSS Aggregator
[resolved] Bug in version 2.2: wprss_feed_source_order assumes everyone is an admin (4 posts)

  1. harrym
    Member
    Posted 1 year ago #

    As written, the function below (inc/custom-post-types.php:143) assumes that all users are administrators:

    function wprss_feed_source_order( $query ) {
            if ( ! is_admin ) {
                return;
            }
    
            $post_type = $query->get('post_type');

    The error is a result of omitting parentheses on the call to is_admin.

    I'm not sure how serious it is that any user can potentially alter this ordering.

    PS - do you develop with notices enabled?

    http://wordpress.org/extend/plugins/wp-rss-aggregator/

  2. jeangalea
    Member
    Plugin Author

    Posted 1 year ago #

    Will fix this in the next release, thanks for pointing it out. Do you mean WP_DEBUG set to true?

  3. harrym
    Member
    Posted 1 year ago #

    Cool, thanks.

    WP_DEBUG will enable notices, yes (and some other things).

  4. jeangalea
    Member
    Plugin Author

    Posted 1 year ago #

    Welcome. Yes that is how I usually develop.

Topic Closed

This topic has been closed to new replies.

About this Plugin

About this Topic

Tags

No tags yet.