WordPress.org

Ready to get started?Download WordPress

Forums

WP Retina 2x
[resolved] PHP Notice Logging (5 posts)

  1. MadysonDesigns
    Member
    Posted 1 year ago #

    Hello-

    I'm noticing a lot of notices in our PHP error logs due to the $_GET 'ms' index being blank:

    PHP Notice: Undefined index: ms in [WP directory]/wp-content/plugins/wp-retina-2x/wr2x_retinaimages.php on line 6, referer: [URL]

    What we've had to do is change the wr2x_retinaimages.php on line 6 from:
    if ($_GET['ms'] && $_GET['ms'] === 'true') {

    to:
    if (isset($_GET['ms']) && $_GET['ms'] === 'true') {

    which solves the problem. But this will obviously be overwritten any time the plugin updates. Suggestions?

    http://wordpress.org/extend/plugins/wp-retina-2x/

  2. Jordy Meow
    Member
    Plugin Author

    Posted 1 year ago #

    Hello,

    Obviously the isset was missing here ;)

    Thanks a lot for noticing. I pushed the changes to the repository so don't worry, the next updates will be fine.

    Thanks again!

  3. MadysonDesigns
    Member
    Posted 1 year ago #

    Fantastic, thanks!

  4. Jordy Meow
    Member
    Plugin Author

    Posted 1 year ago #

    Is it working fine Madyson?
    Can I ask you to review the plugin? I really need those reviews :) http://wordpress.org/support/view/plugin-reviews/wp-retina-2x Thanks a lot for your help ^^

  5. MadysonDesigns
    Member
    Posted 1 year ago #

    Happy to post a review! Thanks so much for your help.

Topic Closed

This topic has been closed to new replies.

About this Plugin

About this Topic