WordPress.org

Ready to get started?Download WordPress

Forums

wp-mpdf
[resolved] Wrong output (4 posts)

  1. hachesilva
    Member
    Posted 2 years ago #

    Hi guys.

    The plugin's HTML output is wrong because it uses an ID instead of a class in order to identify the link:
    <a href="http://example.com/?p=10&output=pdf"> My Text</a>

    So, if you have the pdf link showing within a loop, there are multiple IDs with the same value "pdfbutton".

    The solution is to convert the id to a class (class="pdfbutton") or even better, converting it to a class and adding an unique id:
    class="pdfbutton" id="pdfbutton-XX", where XX is the post ID.

    As a side note: It would be useful for us to have a github repo for the plugin so we can fork, edit and push-request the code, that way we can contribute to it too.

    Thanks for the plugin.

    Cheers.

    http://wordpress.org/extend/plugins/wp-mpdf/

  2. fkrauthan
    Member
    Plugin Author

    Posted 2 years ago #

    Hi,

    Fixed id to class in the next version (2.9.3) which should appear soon.

    The problem is wordpress dosen't support github. I have a svn repo from wordpress and i have to tag a version to publish it to the plugin repository.

    Florian

  3. fkrauthan
    Member
    Plugin Author

    Posted 2 years ago #

    At the moment I migrating my plugin to github. The github url would be github.com/fkrauthan/wp-mpdf

  4. hachesilva
    Member
    Posted 2 years ago #

    Great, and thanks for the credit.

Topic Closed

This topic has been closed to new replies.

About this Plugin

About this Topic