WordPress.org

Ready to get started?Download WordPress

Forums

WP Minify
Most USELESS Feature in this Plugin --> "use newlines before 1st attribu (3 posts)

  1. Kimberly
    Member
    Posted 2 years ago #

    I decided to give this plugin a try and found an odd feature for its HTML minifier. When you enable HTML minification and check the source of your page you will notice a newline after every tag...huh? Exactly! So this plugin adds more characters than it saves. Its really quite baffling because when you check the php file that is doing this you see the author intended to do this..its not a bug. So i have to assume it was a mental relapse or something.

    By him removing the following from his php code it will improve his plugin. Until then i have removed it on my side and dont intend to update it again:

    // use newlines before 1st attribute in open tags (to limit line lengths)
    $this->_html = preg_replace('/(<[a-z\\-]+)\\s+([^>]+>)/i', "$1\n$2", $this->_html);

    http://wordpress.org/extend/plugins/wp-minify/

  2. Kimberly
    Member
    Posted 2 years ago #

    I'm back. Ok after using this plugin more and adding my above "patch" i like the plugin. So i hope the author doesnt think i am bashing his work. He did a great job. It was just the out of place addition in a plugin that is all about minifying.

    There are also a few other bugs like Cache time cant be changed to anything but 900.

  3. gavsiu
    Member
    Posted 1 year ago #

    It's not the author of this plugin. It's the php app that they used.

    http://code.google.com/p/minify/source/browse/min/lib/Minify/HTML.php#138

Topic Closed

This topic has been closed to new replies.

About this Plugin

About this Topic

Tags

No tags yet.