[Plugin: WP-dTree] Open to selection…

Link?

No that’s not the way it’s supposed to work. Open To Selection = opens to (and optionally highlights) the current post, category or archive, respectively.

I need access to the site to help. But you can test if there’s a difference when using permalinks or not. Make sure you’re not using “force open to”. Try running two types of trees; a category and an archive, see if their behaviour differs.

You have discovered an edge case. I probably never tested without listing posts.

I’ve added this this to my list. I’ll let you know when a new release is out.

Actually, no. It’s not an ID clobbering. The script simply assumes the ID passed to “openTo” is valid. If it doesn’t find it in the tree it will open to the index. Your category “Coding” (ID = -110) is actually the 11nth node in the tree. Similarly; your “Imprint” (page id = 78) opens the three to index 78 (which happens to be a post on Alexa rankings).

I need some time to set up and test a fix, but perhaps you can try it yourself?

The offending function is wpdTree.prototype.openTo in wp-dtree.js. I believe all we need to do is remove the conditional from the lookup loop to always run it, and abort if there’s no matching node.

However; I’m not sure what side effects this might cause. Mr. Landrö probably had a reason to put the conditional there in the first place.

Checking for the ID is not a problem; that check is being done. But even if the ID isn’t found the function progresses, treating the ID as an index. Our problem now is to find why it was written this way, or rather what side-effects it might cause to change the behaviour.

I like your look-up solution though. Remember doing that often in ActionScript 2; the String-functions were way faster than to iterate-and-compare through an Array.

All you need to do to test this for me is change this:

wpdTree.prototype.openTo = function(nId, bSelect, bFirst){
	if(!bFirst){
		for (var n=0; n<this.adtNodes.length; n++){
			if(this.adtNodes[n].id == nId){
				nId=n;
				break;
			}
		}
	}
	var cn=this.adtNodes[nId];
	if(cn.pid==this.root.id || !cn._p) return;
	cn._io = true;
	cn._is = bSelect;
	if(this.completed && cn._hc) this.nodeStatus(true, cn._ai, cn._ls);
	if(this.completed && bSelect) this.s(cn._ai);
	else if(bSelect) this._sn=cn._ai;
	this.openTo(cn._p._ai, false, true);
};

(http://pastebin.com/Wy81h3Mm)

To this:

wpdTree.prototype.openTo = function(nId, bSelect, bFirst){
	for (var n=0; n<this.adtNodes.length; n++){
		if(this.adtNodes[n].id == nId){
			nId=n;
			var cn=this.adtNodes[nId];
			if(cn.pid==this.root.id || !cn._p) return;
			cn._io = true;
			cn._is = bSelect;
			if(this.completed && cn._hc) this.nodeStatus(true, cn._ai, cn._ls);
			if(this.completed && bSelect) this.s(cn._ai);
			else if(bSelect) this._sn=cn._ai;
			this.openTo(cn._p._ai, false, true);
		}
	}
};

(http://pastebin.com/0Fn8uNv0)

wp-dtree.js does not seem to be used but wp-dtree.min.js […]

… so either read what I’ve said, or – you know – copy the content of one into the other? Whichever makes you happy.

Check. I need to set up a test environment and sort this out. You’ll be notified when a new version is out.