WordPress.org

Ready to get started?Download WordPress

Forums

WordPress SEO by Yoast
[resolved] Turn php errors to E_ALL and fix notices and warnings please! (7 posts)

  1. beetlefish
    Member
    Posted 2 years ago #

    Love your plugins - but I'm getting a lot of php error messages - granted not fatal. Please fix them.

    We have a zero tolerance for notices even if display errors is off. We have to fix your code before we deploy and we'd rather not touch the core of your plugin for better upgrades in the future.

    http://wordpress.org/extend/plugins/wordpress-seo/

  2. Joost de Valk
    Member
    Plugin Author

    Posted 2 years ago #

    Dude, be more specific. My plugin currently throws no notices I'm aware of and I always have E_ALL on.

  3. beetlefish
    Member
    Posted 2 years ago #

    Notice: Undefined index: fb_admins in /wp-content/plugins/wordpress-seo/admin/class-config.php on line 1172

    And we are still seeing a periodic undefined index from wp-content/plugins/wordpress-seo/frontend/class-frontend.php on line 361

    I believe the index is "link". But it's periodic so I can't cut and paste it here.

    We already deployed your earlier upgrade to 1.1.6. We will deploy 1.1.7 tomorrow.

  4. Joost de Valk
    Member
    Plugin Author

    Posted 2 years ago #

    That second one was fixed in 1.1.7 I think, just fixed the first one in trunk for the next release.

  5. BarryW_wm
    Member
    Posted 2 years ago #

    Hello. Another one for you, in 1.1.7:

    Notice: Undefined index: metakey-page in plugins/wordpress-seo/frontend/class-frontend.php on line 511

    I think this is caused by the || operator taking precedence over the && isset() in the conditional on the previous line.

    Cheers

  6. beetlefish
    Member
    Posted 2 years ago #

    Another one ...

    Notice: Undefined variable: datestr in /wp-content/plugins/wordpress-seo/admin/class-metabox.php on line 437

  7. Joost de Valk
    Member
    Plugin Author

    Posted 2 years ago #

    Thanks! Will fix both for 1.1.8

Topic Closed

This topic has been closed to new replies.

About this Plugin

About this Topic