WordPress.org

1. Clifford P
   Member
   Posted 6 months ago #

   functions.inc.php

   Line 162

   Changed from this:
   <td class="value"><img src="'.$wp_dlm_root.'img/bar.png" alt="" height="16" width="0%" />0</td>

   To this:
   <td class="value"><img src="'.plugins_url('/download-monitor/img/bar.png').'" alt="" height="16" width="0%" />0</td>

   Line 189

   Changed from this:
   echo '<a href="'.$url.'" class="thickbox" title="'.__('Add Download','wp-download_monitor').'"><img src="'.$wp_dlm_root.'/img/media-button-download.gif" alt="'.__('Add Download','wp-download_monitor').'"></a>';

   To this:
   echo '<a href="'.$url.'" class="thickbox" title="'.__('Add Download','wp-download_monitor').'"><img src="'.plugins_url('/download-monitor/img/media-button-download.gif').'" alt="'.__('Add Download','wp-download_monitor').'"></a>';

   admin/dashboard.php

   Line 169

   From this:
   <td class="value"><img src="'.$wp_dlm_root.'img/bar.png" alt="" height="16" width="'.$width.'%" />'.$hits.'</td>

   To this:
   <td class="value"><img src="'.plugins_url('/download-monitor/img/bar.png').'" alt="" height="16" width="'.$width.'%" />'.$hits.'</td>

   Line 242

   From this:
   <td class="value '.$first.' '.$last.'"><img src="'.$wp_dlm_root.'img/bar.png" alt="" height="16" width="'.$width.'%" />'.$hits.'</td>

   To this:
   <td class="value '.$first.' '.$last.'"><img src="'.plugins_url('/download-monitor/img/bar.png').'" alt="" height="16" width="'.$width.'%" />'.$hits.'</td>

   http://wordpress.org/extend/plugins/download-monitor/

2. Clifford P
   Member
   Posted 6 months ago #

   Okay, I realized there are A LOT of places to change... and this is a quicker fix anyways (ignore the previous post I guess)...

   wp-download-monitor.php

   Line 35

   From this:
   $wp_dlm_root = WP_PLUGIN_URL."/download-monitor/";

   To this:
   $wp_dlm_root = plugins_url('/download-monitor/');

   That fixed 'em all. :)

   P.S. Just for consistency's sake...
   admin/admin.php

   Line1446

   From this:
   if (!$thumb) $thumb = $wp_dlm_root.'/page-addon/thumbnail.gif';

   To this:
   if (!$thumb) $thumb = $wp_dlm_root.'page-addon/thumbnail.gif';
   (took out the extra /)

   Please implement this or some other fix into the next version.

3. jeremyclarke
   Member
   Posted 6 months ago #

   +1 this is mandatory! For now I will have to hack the plugin with this same fix, but PLEASE, fix this ASAP. it is a simple fix and follows current best practices for fetching URLS. (plugins_url(), content_url(), site_url() are all new and awesome and SSL-friendly).

   Thanks!

4. Mike
   Member
   Posted 6 months ago #

   Thanks, added. DLM needs a good update but sadly I lack the time at the moment due to other commitments.

   https://github.com/mikejolley/download-monitor/

5. Clifford P
   Member
   Posted 5 months ago #

   Thanks, Mike!

6. Mvied
   Member
   Posted 5 months ago #

   If anyone else notices issues like this in plugins, you can use WordPress HTTPS to fix the elements that are not SSL aware without editing the offending plugin.

7. jeremyclarke
   Member
   Posted 5 months ago #

   Good point Mvied, though output buffering the entire admin/site is a tradeoff that many people should think twice about (but which most users will never understand), and if the fixes for plugins are easy then plugin devs should make the small changes rather than encourage users to install an intense plugin like WPHTTPS.

   No offense meant to your plugin of course, it's invaluable for people who don't care about performance (or dont' have problems that output buffering exacerbates), but I hope other plugin devs don't use it as an excuse ;)

Reply

You must log in to post.