WordPress.org

Ready to get started?Download WordPress

Forums

Widget Wrangler
[resolved] Adv Parsing gets lost after Quickedit (6 posts)

  1. JochenT
    Member
    Posted 2 years ago #

    Hi,

    tremendous good plugin.

    Unfortunately I've found a smaller bug (although it may become dangerous).
    After cloning a widget the advanced parsing is enabled automatically. After saving the cloned widget and editing it using the Quickedit mode of WP, all Advanced Parsing content is lost. The Advanced parsing flag itself is also disabled.

    http://wordpress.org/extend/plugins/widget-wrangler/

  2. Jonathan Daggerhart
    Member
    Plugin Author

    Posted 2 years ago #

    Thank you for the report.

    I'll look into this and see what I can do. If I can't fix the issue, I may end up disabling quick edit.

    Could you describe how you were quick editing? Were you just changing the widget's title or something simple like that?

    Thanks,
    Jonathan

  3. JochenT
    Member
    Posted 2 years ago #

    A quick edit saves the whole edit page form. As your specific variables are not defined at this point, they are deleted.
    I've found this problem in anotrher plugin, too. As the quick edit options usually do not affect the plugin specific variables I use a hidden input to prevent deletion.
    I added <input type="hidden" name="formSubmitted" value="true" /> into the form and check following statement at the beginning of the save handler:

    //Check if this call results from another event, like the "Quick Edit" option
    			if ($_POST['formSubmitted'] != "true")  { return; }

    I hope this solution is useful to you.

  4. Jonathan Daggerhart
    Member
    Plugin Author

    Posted 2 years ago #

    That worked. Thanks for the help.

    Changes are in the most recent version.

  5. JochenT
    Member
    Posted 2 years ago #

    Hi,

    thank you for the quick reaction. Unfortunately this modification creates a bigger problem. Now it is not possible to save the Advanced Parsing part of a Widget Wrangler CPT any more.

    Currently the line <input type="hidden" name="formSubmitted" value="true" /> is placed in function edit_columns($columns). I've moved this into the html part of function meta_parse(). As this meta-box is always saved when saving the page (although it might be not visible), the hidden flag is properly transferred to the save handler.

    Now I'm able to save the Advanced Parsing part again.

    Just for info:
    I've tested some more sophisticated widgets with Widget Wranglers cloning functionality and had following results:

    • Plugin Mini Loops (allows templating of listings of CPTs): WORKS
    • Plugin Ultimate Tag Cloud: PARTIALLY (only numerical tag IDs work, saved config gets lost)
    • Plugin Spots (associates a text widget with a CPT): FAILS
  6. Jonathan Daggerhart
    Member
    Plugin Author

    Posted 2 years ago #

    Thank you! Sorry about that. Just pushed another release with that fix.

    I'll take a look at the plugins you mention.

Topic Closed

This topic has been closed to new replies.

About this Plugin

About this Topic