WordPress.org

Ready to get started?Download WordPress

Forums

Viper's Video Quicktags
[resolved] Vimeo Embed Failing if using HTTPS in Vimeo URL (11 posts)

  1. Curtiss Grymala
    Member
    Posted 2 years ago #

    Came across a bug in the plugin this morning. If the Vimeo link uses https in its URL, the plugin builds the iFrame src URL incorrectly.

    For example, if you try to use the Vimeo link https://vimeo.com/42617831, the plugin will set up the iFrame as:

    <iframe id="vvq-45381-vimeo-1" src="http://player.vimeo.com/video/https://vimeo.com/42617831?title=1&byline=1&portrait=0&fullscreen=1" width="400" height="300" frameborder="0"><a href="http://www.vimeo.com/https://vimeo.com/42617831">http://www.vimeo.com/https://vimeo.com/42617831</a></iframe>

    Notice that the URL being used for the iFrame src is http://player.vimeo.com/video/https://vimeo.com/42617831 instead of simply http://player.vimeo.com/video/42617831. Thanks.

    http://wordpress.org/extend/plugins/vipers-video-quicktags/

  2. ayron
    Member
    Posted 2 years ago #

    Hi,

    Sorry to post the topic off topic, but I tried the last activity in order to interact with you.

    REF: Post Content Shortcodes

    I checked the log for version 0.3. I found very interesting the option of using posts from other blogs in a multisite environment ..

    [post-content blog_id = 12 id = 25]

    Any predictions for this version 0.3 release?

    Thank's

    Fernando Eduardo Lourenço
    Brazil

  3. ninnypants
    Member
    Posted 2 years ago #

    The issue is that the plugin currently only checks for http urls to enable https you can modify the file and replace
    'http://' == substr( $content, 0, 7 )
    with
    preg_match( '#^https?://#i', $content )

  4. KaraLeah
    Member
    Posted 2 years ago #

    Need a bit more instruction... modify which file and which line of code is 'http://' == substr( $content, 0, 7 )?

    Thanks!

  5. Alex Mills (Viper007Bond)
    Moderator
    Plugin Author

    Posted 2 years ago #

    ninnypants sent me a patch -- I'll push the fix out to my plugin soon.

  6. KaraLeah
    Member
    Posted 2 years ago #

    Alex,

    You rock, thank you!

  7. DanWell
    Member
    Posted 2 years ago #

    Have just come across the same issue.
    Does anyone know when the update/fix will be released?
    Thanks

  8. KaraLeah
    Member
    Posted 2 years ago #

    Hey DanWell,

    My impression was that Alex was going to have it done a few weeks ago. I've given up waiting though - needed to get my Vimeo videos embedded. Found a different plug-in which works perfectly. Seems to work alongside Alex's with no issues either. Although I went back and transferred all my other embeds to the new plug-in, just so I only have one running.

    It's called "TentBlogger Vimeo, YouTube, RSS Embed"

  9. DanWell
    Member
    Posted 2 years ago #

    Thanks KaraLeah
    I also went and found another plugin imaginatively called 'wordpress video plugin' which seems to do the job fine. It doesn't have the same level of control as Viper's though so I'll keep an eye out for Alex's update and will look at TentBlogger in the meantime.

  10. Alex Mills (Viper007Bond)
    Moderator
    Plugin Author

    Posted 2 years ago #

    Fixed in v6.4.2.

    4th of July and my 9 to 5 got in the way.

  11. Christopher Ditto
    Member
    Posted 1 year ago #

    Playing Vimeo videos from an HTTPS page still doesn't work for me. The https URL passes verification (is_url function) within the plugin but the vimeo URLs don't change to https (which is necessary for it to work).

    Here's what I changed in the plugin to get it to work for Vimeo:

    Changed:
    $iframeurl = 'http://player.vimeo.com/video/' . $videoid;
    /* to */
    $protocol = 'http';
    if (strpos($content, 'https://') !== FALSE)
    $protocol = 'https';
    $iframeurl = $protocol.'://player.vimeo.com/video/' . $videoid;

    and changed:
    return '<span class="vvqbox vvqvimeo" style="' . esc_attr( 'width:' . $atts['width'] . 'px;height:' . $atts['height'] . 'px;' ) . '"><iframe id="' . esc_attr( $objectid ) . '" src="' . esc_url( $iframeurl ) . '" width="' . esc_attr( $atts['width'] ) . '" height="' . esc_attr( $atts['height'] ) . '" frameborder="0">' . esc_url( 'http://www.vimeo.com/' . $videoid ) . '</iframe></span>';

    to

    return '<span class="vvqbox vvqvimeo" style="' . esc_attr( 'width:' . $atts['width'] . 'px;height:' . $atts['height'] . 'px;' ) . '"><iframe id="' . esc_attr( $objectid ) . '" src="' . esc_url( $iframeurl ) . '" width="' . esc_attr( $atts['width'] ) . '" height="' . esc_attr( $atts['height'] ) . '" frameborder="0">' . esc_url( $protocol.'://www.vimeo.com/' . $videoid ) . '</iframe></span>';

    Hope this helps someone.

Topic Closed

This topic has been closed to new replies.

About this Plugin

About this Topic