WordPress.org

1. oncletom
   Member
   Posted 1 year ago #

   Hello,

   first of all, thanks for your plugin. It's defintively a good thing to ease their embedding within a post.

   I have concerns on loading swfobject.
   Here are 2 requests to improve page loading.

   1) load swfobject.js only when necessary
   I use post excerpt, not post content within loops (search, archives etc.). Most of all, not all posts can contain videos during the loop.

   My request is thus the following: during the first query, load the swfobject only if any queried post contains a video shortcode.
   To let theme developpers handling their excerpt, maybe you could include a filter at the time you check this, to override this, in whatever way they want.

   2) enable to load videos without swfobject
   This solution was introduced to bypass IE limitation, declined a couple of years ago. So it's rather counterproductive to load a video asynchroneously if it's part of the content.
   A simple checkbox option "Load video through SWFObject" should be fine, such as filter, as always to let theme and plugin developpers to hook on this.

   If you need more precise and clear proposal, just tell me, I'll try to help :-)

   Thanks for your concern!

   http://wordpress.org/extend/plugins/vipers-video-quicktags/

2. oncletom
   Member
   Posted 1 year ago #

   This is tied to the other script tag, initializing Flashvars (this could be done at the same moment where the video is loaded.

3. Alex Mills (Viper007Bond)
   Moderator
   Posted 1 year ago #

   1) Looking forward at what posts are going to be displayed is unreliable and doesn't always work. In the next major release of my plugin, I'll try and get this to perform better though.

   2) SWFObject will be used to enhance/fix embeds rather than doing that actual embeds in the next major release of my plugin. I've just been busy as hell, so it hasn't been released yet. :)

4. oncletom
   Member
   Posted 1 year ago #

   For the point #1, yes I agree. I guess the minimal check would be to hook on posts_selection action, and test if the post content contains a video shortcode.
   With a filter/action, it can let theme developers or plugins a way to extend this basic selection.

   For point 2, cool. I'll just wait for it then :-)

   Thanks!

5. Alex Mills (Viper007Bond)
   Moderator
   Posted 1 year ago #

   With a filter/action, it can let theme developers or plugins a way to extend this basic selection.

   Except if they don't do it, then I have to listen to users complaining about my plugin not working correctly.

Topic Closed

This topic has been closed to new replies.