WordPress.org

Ready to get started?Download WordPress

Forums

Tipsy Social Icons
[resolved] Class name mi (3 posts)

  1. Pepperfly
    Member
    Posted 2 years ago #

    I was having problems getting the social icons to float right. The floated element was dropping low. I noticed this line:

    .tipsy-social-icons { display: inline; }

    That is good, but I also noticed something bad on line 8 of tipsy-social-icons-content.php:

    <img src="<?php echo WP_PLUGIN_URL . '/tipsy-social-icons/images/' . $icon_size . '/' . $key . '_' . $icon_size . '.png'; ?>" alt="<?php echo ucfirst($key); ?>" class="tipsy-social-icon" />

    Do you see it, too? The class name is mismatched. I added the "s" to the end of the class name and my problem was resolved.

    It's took me about 5 hours to figure this out. <acK!> ;-)

    http://wordpress.org/extend/plugins/tipsy-social-icons/

  2. tommcfarlin
    Member
    Plugin Contributor

    Posted 2 years ago #

    Just resolved this and checked in an update.

    Thanks for posting this - good catch!
    Tom

  3. Pepperfly
    Member
    Posted 2 years ago #

    NP! You owe me a free lifetime license and unlimited support <grin>. ;-)

    IE8 fully exploited the issue. The other (good) browsers and other versions of IE exhibited the issue, too, but it was so slight that it was virtually unnoticeable. In fact, until it was fixed I didn't even realize there was a problem at all with the other browsers/IE versions, but could perceptively see the improvement afterward. Anyway, since it stuck out like a sore thumb in IE8, that led me to believe that it was one of the dreaded known IE8+CSS issues when floating elements. There are work-arounds, and I was down to the last trick in the book, which was the most aggressive work-around and required additional styles in tipsy-social-icons.css and a class in the markup in tipsy-social-icons-content.php. Not knowing how much code I'd have to sift through to find the place I wanted to add the class, I was ready to search on ".tipsy-social-icons," but was surprised to see very little code and I was able to scan through quite quickly and the discrepancy jump out right away. Only reason it took me 4-5 hours to figure out is because I really thought it was an IE8 issue all along (and, boy-oh-boy, I was cussin' out IE the whole time!), not a plugin issue, so was focused on a bug work-around that wasn't really there <heh>. #canibuyavowel? ;-) #sorrymicrosoft #iestillsucks!

Topic Closed

This topic has been closed to new replies.

About this Plugin

About this Topic