WordPress.org

Ready to get started?Download WordPress

Forums

Theme My Login
Parameter 'instance' in function theme_my_login() is ignored (4 posts)

  1. Alexander Gieg
    Member
    Posted 2 years ago #

    The function theme_my_login() is ignoring the 'instance' parameter when set, and generating a new one. Changing line 591 in includes/class-theme-my-login.php from:

    } else {

    to:

    } elseif ( !isset($atts['instance']) || !is_string($atts['instance']) || '' == trim($atts['instance']) ) {

    fixes this, allowing for more predictable form ids and making the function behave as told in the documentation.

    I hope this helps!

    EDIT: Added empty string test.

  2. Jeff Farthing
    Member
    Plugin Author

    Posted 2 years ago #

    Good point. Surprised nobody else has noticed this before.

  3. Alexander Gieg
    Member
    Posted 2 years ago #

    I have other minor edits too, mostly translation related, as I needed a pt-BR version and went ahead and just finished translating the whole thing. :-) Where should I send those (plus the po/mo files)? Can I provide them as a single unified diff file?

  4. Jeff Farthing
    Member
    Plugin Author

    Posted 2 years ago #

    I actually already have a full translation of Brazilian Portuguese, just waiting for 6.4. I have also commited a fix to allow setting of the instance parameter.

Topic Closed

This topic has been closed to new replies.

About this Plugin

About this Topic