Support » Plugin: Theme My Login » [Plugin: Theme My Login] Parameter 'instance' in function theme_my_login() is ignored

  • The function theme_my_login() is ignoring the ‘instance’ parameter when set, and generating a new one. Changing line 591 in includes/class-theme-my-login.php from:

    } else {

    to:

    } elseif ( !isset($atts['instance']) || !is_string($atts['instance']) || '' == trim($atts['instance']) ) {

    fixes this, allowing for more predictable form ids and making the function behave as told in the documentation.

    I hope this helps!

    EDIT: Added empty string test.

Viewing 3 replies - 1 through 3 (of 3 total)
  • Plugin Author Jeff Farthing

    (@jfarthing84)

    Good point. Surprised nobody else has noticed this before.

    Thread Starter Alexander Gieg

    (@alexgieg)

    I have other minor edits too, mostly translation related, as I needed a pt-BR version and went ahead and just finished translating the whole thing. 🙂 Where should I send those (plus the po/mo files)? Can I provide them as a single unified diff file?

    Plugin Author Jeff Farthing

    (@jfarthing84)

    I actually already have a full translation of Brazilian Portuguese, just waiting for 6.4. I have also commited a fix to allow setting of the instance parameter.

Viewing 3 replies - 1 through 3 (of 3 total)
  • The topic ‘[Plugin: Theme My Login] Parameter 'instance' in function theme_my_login() is ignored’ is closed to new replies.