WordPress.org

Ready to get started?Download WordPress

Forums

Term Menu Order
[resolved] Deactivating the plugin should not remove the menu_order data (2 posts)

  1. GeertDD
    Member
    Posted 2 years ago #

    In NS_TMO_Plugin->deactivate(), the column "menu_order" gets dropped from the terms table. This means all this data gets thrown away and you need to start over upon reactivation. Shouldn't it be better to only remove this data when the plugin gets uninstalled?

    Also see: http://wordpress.stackexchange.com/questions/715/objective-best-practices-for-plugin-development/717#717

    http://wordpress.org/extend/plugins/term-menu-order/

  2. Bill Erickson
    Member
    Plugin Author

    Posted 2 years ago #

    I've just updated the plugin to remove the data on deletion, not deactivation: https://github.com/billerickson/Term-Menu-Order/commit/331284d402e13c6d03ab7aa31fb9008749512682

    It will be a part of the next release.

    Thanks

Topic Closed

This topic has been closed to new replies.

About this Plugin

About this Topic