WordPress.org

Ready to get started?Download WordPress

Forums

Subscribe2
Inconsiderate mark-up (4 posts)

  1. ldexterldesign
    Member
    Posted 3 years ago #

    Recommendation:

    <p>That email address is not subscribed.</p>

    ... to:

    <p><em class="notify flag error youGetTheIdea">That email address is not subscribed.</em></p>

    Inconsiderate mark-up is the only reason I'm not awarding this 5-stars. I have to go into the PHP to do the job of the plug-in maker.

    If you'd like a hand drop me an email: mail@ldexterldesign.co.uk

    Thanks for your work,

  2. mattyrob
    Member
    Plugin Author

    Posted 3 years ago #

    @ldexterldesign,

    I'm not entirely sure that I understand the point you are trying to make. Obviously you want to change to formatting of the plugin messages but the code you've posted will put the message into italics for all users.

    Why would this make the mark-up considerate?

    I've also sent you an email direct. I'm happy to accept patches and suggestions for the code but I write it to work for me on my sites and then share it freely (in the non-HTML form) as others seem to find it useful also. I cannot guarantee that I'll add any suggestion or patch to the core code but I do promise to consider them all.

  3. ldexterldesign
    Member
    Posted 3 years ago #

    'Obviously you want to change to formatting of the plugin messages...'

    - yes, but I've HAD to detail the mark-up in order to hang my styles off it. It's annoying for front-end developers, like myself, who use WordPress plug-ins, no less average users with basic CSS knowledge, to have to go into PHP to find and amend (sloppy) mark-up.

    '...but the code you've posted will put the message into italics for all users'

    - true, but remember the primary importance of HTML is meaning, not styling.

    Not only does <em> provide the correct meaning (emphasis) to any validation errors/flags/ or notifications IMO, it also has the added benefit of providing a more granular marker to hang styles off.

    I would consider any of the following 'correct' alternatives, but some marker would be better than nothing!:

    <p><span class="notify flag error youGetTheIdea">That email address is not subscribed.</span></p>
    <p class="notify flag error youGetTheIdea">That email address is not subscribed.</p>

    Thanks for your email Matt. I hope this is a suitable explanation.

    Best,

  4. mattyrob
    Member
    Plugin Author

    Posted 3 years ago #

    @ldexterldesign,

    Thanks for following up and the explanation. I understand much better the addition of a class to the existing messages and that's something I should be able to get into the next version.

    I'll probably use the last of your recommended approaches - defining a class in the <p> tags.

Topic Closed

This topic has been closed to new replies.

About this Plugin

About this Topic

Tags