Hi there,
I needed to use the blog's name as sender name for the notification emails, so I wrote a small patch for it. It is tested successfully with WP 3.0.3. Can I send it to you (mail etc)?
Greetings,
Andreas
Hi there,
I needed to use the blog's name as sender name for the notification emails, so I wrote a small patch for it. It is tested successfully with WP 3.0.3. Can I send it to you (mail etc)?
Greetings,
Andreas
@Andreas,
I'm always happy to accept code submissions but cannot guarantee that they go into the core. I will never share the code in any other form though to ensure that I don't infringe your copyright.
If you want to share your code put it on pastebin.com and post the link to the code here.
Hello Rob,
of course I won't enforce you to integrate my patch :)
As you suggested, I have posted the diff file (against Subscribe 6.1) on pastebin: http://pastebin.com/NdW57eDn
@Andreas,
That's a neat diff and a good addition to the code. I'll adopt that into the next release. The only change I've made to your patch is to use get-option() rather than get_bloginfo(). Many of the attributes of the latter function are deprecated in favour of get_option() and I suspect that the whole function may follow so I think it makes sense to avoid using it where possible.
I didn't know about get_option() yet - thank you for enlightening me!
This topic has been closed to new replies.