WordPress.org

Ready to get started?Download WordPress

Forums

Speaker Deck Embed
[resolved] add https support (4 posts)

  1. baxang
    Member
    Posted 1 year ago #

    Hi,

    I found your useful plugin and I thank you for it. However I didn't work for me so I tried to figure it out and found that the link address Speakerdeck provides is https, not http. So I tried to fix your code a bit to use a regular expression rather than the simple wildcard format as below:

    wp_oembed_add_provider( '#http(s)?://speakerdeck.com/u/.*/p/.*#i', 'http://speakerdeck.com/oembed.json', true );

    I hope someone find this useful.

    Sanghyun

    http://wordpress.org/extend/plugins/speakerdeck-embed/

  2. I've updated @baxang's patch to work with the new format Speaker Deck URLs (https://speakerdeck.com/[username]/[presentation]). The new code is:

    wp_oembed_add_provider( '#https?://speakerdeck.com/.*#i', 'https://speakerdeck.com/oembed.json', true );

    @mattwiebe – Here's a diff or here's a complete new plugin file.

  3. Matt Wiebe
    Member
    Plugin Author

    Posted 1 year ago #

    Thanks @baxang and @simonwheatley. Just pushed 1.1 with the new format.

    Also: baxang, sorry about missing this for so long. Apparently I wasn't subscribed to me own plugin's topic. :/

  4. baxang
    Member
    Posted 1 year ago #

    I'm glad to see my suggestion made a small improvement :) Thanks for the work guys!

Topic Closed

This topic has been closed to new replies.

About this Plugin

About this Topic

Tags

No tags yet.