WordPress.org

Ready to get started?Download WordPress

Forums

Social Connect
Social-Connect fails on IE7. (10 posts)

  1. deenorris
    Member
    Posted 3 years ago #

    Webpage error details

    User Agent: Mozilla/4.0 (compatible; MSIE 7.0; Windows NT 5.1; Trident/4.0; .NET CLR 2.0.50727; .NET CLR 3.0.4506.2152; .NET CLR 3.5.30729; msn OptimizedIE8;ENUS)
    Timestamp: Thu, 10 Mar 2011 17:10:33 UTC

    Message: Expected identifier, string or number
    Line: 26
    Char: 7
    Code: 0
    URI: http://www.transexualmenace.org/wp-content/plugins/social-connect/media/js/connect.js?ver=3.1

    http://wordpress.org/extend/plugins/social-connect/

  2. markusdrake
    Member
    Posted 3 years ago #

    I thought twice before posting on this particular thread just because of the above user's web site url... ... ...

    But, this is an issue I am currently experiencing with the plug in as well. Seems your JavaScript file is not working in IE7 or 8. Can anyone confirm that to be untrue? I have not modified any core files of the plugin and definitely have not touched the JS file, though I plan to if I don't hear anything back.

    This is definitely a great plugin, and I want to continue using it.

    Webpage error details

    User Agent: Mozilla/4.0 (compatible; MSIE 8.0; Windows NT 6.1; Trident/4.0; SLCC2; .NET CLR 2.0.50727; .NET CLR 3.5.30729; .NET CLR 3.0.30729; Media Center PC 6.0; .NET CLR 3.5.21022; SLCC1)
    Timestamp: Mon, 4 Apr 2011 17:24:12 UTC

    Message: Expected identifier, string or number
    Line: 26
    Char: 7
    Code: 0
    URI: *MASKED*/wp-content/plugins/social-connect/media/js/connect.js?ver=3.1

  3. deenorris
    Member
    Posted 3 years ago #

    Just kinda a curious why the URL would matter when posting a bug report! Did you think you would get cooties just by posting on the same thread?

    Sheesh!

  4. thenbrent
    Member
    Plugin Author

    Posted 3 years ago #

    @markusdrake if you're willing to take a look at the JS that would be great! If you find the error please post it here or make a pull request on GitHub: http://github.com/thenbrent/social-connect

    @deenorris the url issue is likely due to spam concerns. To be honest, the first time I saw the post I thought it was spam as it consists mostly of an auto-generated error message. The error message is very helpful mind you, so thanks for providing it and sorry for assuming it was spam. :)

  5. markusdrake
    Member
    Posted 3 years ago #

    I found the issue, it's actually a pretty simple error but it relieved the issue I was having with IE 7 and 8 and now allows the script to run completely.

    When including multiple functions it's normally okay to do this:

    function name(){}, function name2(){},

    However leaving that last comma on the end throws exceptions in IE. On Line 25 you have a close function for your dialog - you want to remove that last comma before line 26 and commit the changes.

  6. deenorris
    Member
    Posted 3 years ago #

    I removed the comma on Line 25 of connect.js and it works correctly now.

    The line now reads:

    close: function(){$(document).unbind('click', overlay_click_close);}

  7. markusdrake
    Member
    Posted 3 years ago #

    Thanks deenorris, it solved the errors on my end as well. I should have posted the actual line like you did too.

  8. deenorris
    Member
    Posted 3 years ago #

    Markus - You did the hard work. I just posted the edit.

    Thanks!

    I guess once they post a working update, we can close this thread.

  9. thenbrent
    Member
    Plugin Author

    Posted 3 years ago #

    Thanks a heap Markus. This fix is now in the development version and will be in a public release on WordPress.org soon (awaiting on a few other changes to be finalised).

  10. billbob69
    Member
    Posted 2 years ago #

    On a different subject, is anyone else getting spam (I assume)through Social Connect? I have reCaptcha on the normal login and it works a treat. Went through a lot to get SC working with Hostgator so I'd like to keep it. Any suggestions?

Topic Closed

This topic has been closed to new replies.

About this Plugin

About this Topic