[Plugin: Simple Lightbox] Bug: rel="slb"'s links to (particularly wiki) pages for ima

  • Resolved Jani Uusitalo

    (@jani-uusitalo)


    12 years, 4 months ago

    It looks like 1.6.1 now automatically adds a rel=”slb” (plus some slb_group) to image links pointing to url’s ending in a known image postfix. While a nice idea in theory, this does not work well with links pointing to non-image content that ends in an image postfix.

    Steps to reproduce:
    1. Create an image link pointing to a picture page in Wikimedia Commons.
    2. Try clicking the link with SLB activated.

    What happens:
    SLB tries to lightbox the Commons page.

    What I expect to happen:
    I’d expect SLB not to mess with the link so that when I click the image, I’m taken to the Commons page as usual.

    Other notes:
    I don’t think there’s any way around this other than disabling the automatic rel=”slb”‘ing feature entirely (which the plugin currently, AFAICS, doesn’t allow me to do). There’s no reliable way to determine a link *really* points to an image just by looking at the url.

    http://wordpress.org/extend/plugins/simple-lightbox/

Viewing 6 replies - 1 through 6 (of 6 total)
  • Plugin Author Archetyped

    (@archetyped)

    12 years, 4 months ago

    Hi,

    Please have a look at the Usage Notes section on SLB’s official page for information on disabling lightbox activation for specific links.

    Thread Starter Jani Uusitalo

    (@jani-uusitalo)

    12 years, 4 months ago

    So, uh, how do I retroactively extend this reversed behavior to all the links on my blog relying on the previous behavior? I think it’s easier for me to just downgrade and freeze the plugin back to where it works the way I’ve relied on it functioning up until now.

    (Not to be critical of your work; it’s your code and you do with it as you will. It just seems my use-case was niche even until recently, and now it’s no longer supported at all.)

    Plugin Author Archetyped

    (@archetyped)

    12 years, 4 months ago

    SLB has always automatically activated image links for display in a lightbox. Perhaps you are thinking of a different lightbox plugin that you previously used?

    Thread Starter Jani Uusitalo

    (@jani-uusitalo)

    12 years, 4 months ago

    Yes and no. 🙂 No, I’ve never used anything but SLB. Yes, it’s apparently always activated links, but it also used to have the ‘Activate all image links in item content’ option. Being able to uncheck that option I could use SLB as I have until now: with lightboxing only on links I’ve manually specified as rel=”slb”. The automatic url-snooping thingy just doesn’t work for me, since I use lots of image links pointing to wiki pages of those images.

    FWIW, it was easy to fix this for myself: I just cut process_links() so that it immediately returns with unprocessed $content.

    Plugin Author Archetyped

    (@archetyped)

    12 years, 4 months ago

    Ah, I see. Yes, the option to enable/disable link activation was removed in v1.6 due to its potential to create confusion with users.

    I’m sorry your use of SLB was caught in the crossfire. I am always looking for ways to improve SLB, so thank you for your candid feedback.

    Thread Starter Jani Uusitalo

    (@jani-uusitalo)

    12 years, 4 months ago

    No problem, and thanks for the rapid response to my bug-report-turned-support-request!

Viewing 6 replies - 1 through 6 (of 6 total)
  • The topic ‘[Plugin: Simple Lightbox] Bug: rel="slb"'s links to (particularly wiki) pages for ima’ is closed to new replies.