WordPress.org

Ready to get started?Download WordPress

Forums

Simple Facebook Connect
Errors! (12 posts)

  1. Gecka
    Member
    Posted 2 years ago #

    Hello,

    I love that plugin but it is full of notice errors. Come on Otto, define('DEBUG", true);

    http://wordpress.org/extend/plugins/simple-facebook-connect/

  2. Samuel Wood (Otto)
    Tech Ninja
    Plugin Author

    Posted 2 years ago #

    Bah. Notices are not errors, they're notices. Turn off debugging on your production systems.

  3. Gecka
    Member
    Posted 2 years ago #

    It just means that the code isn't written how it should be.

    It is annoying because when I develop I work with debugging to avoid these errors. But your plugin is polluting the output with its own errors, which wordpress itself doesn't do.

  4. Samuel Wood (Otto)
    Tech Ninja
    Plugin Author

    Posted 2 years ago #

    "Should" is relative. I don't consider notices to be errors, and I develop with them off.

    They may be eliminated in some future version, but it is not a priority at this time.

    If you want to email me a patch, I'm perfectly happy to take a look at it. Make sure you use the trunk version of the plugin, that's where the latest code is: http://plugins.svn.wordpress.org/simple-facebook-connect/trunk/

  5. Gecka
    Member
    Posted 2 years ago #

    Programming with E_ALL is a well known PHP best practice in the PHP developers world.

    I'll send you a patch when I'll get time. SVN and patches are a pain compared to github Fork/Pull/Push feature.

  6. Samuel Wood (Otto)
    Tech Ninja
    Plugin Author

    Posted 2 years ago #

    What it world it would be if we all agreed, eh? ;)

    Also, git annoys me. Seriously, it's like, backwards and weird. Give me patch files any day. At least I can *read* them.

  7. Gecka
    Member
    Posted 2 years ago #

    It would be a great world if everyone was following the coding best practices. Most other languages do not allow using unassigned vars for good reasons, that you are certainly aware of.

    http://stackoverflow.com/questions/5073642/why-should-i-fix-e-notice-errors

    Concerning GIT it is a fantastic thing, especially the Fork/Push/Pull feature from GitHub. At least it keeps the credit of any modification to its author and it encourages contributions, and thus open source projects using it get better.

    There are good reason that most open source project are slowly moving to it.

    Here is an example of a wordpress plugin that got big benefits from it

    Anyway I told you that I'll send you a patch when I have time because SVN and patches are a pain, and even if I may loose the credit for it.

  8. Samuel Wood (Otto)
    Tech Ninja
    Plugin Author

    Posted 2 years ago #

    "Best practices" are up for debate. They are not necessarily a fixed point. C had the equivalent of "notices" too. Try compiling some open source C sometime.

    Anyway, I've looked at git and GitHub, and I have an account there, but after looking at it, I'm not sure that I can use it in a meaningful way. It strikes me as suitable for a different type of project... one which I probably wouldn't be involved in because of the overbearing complexity.

    The underlying premise of git bugs me and I dislike it because of the decentralized nature. Who knows, maybe eventually I'll see the point, but right now, for me, a project being based around git is a project that I would very likely not contribute to.

  9. jason102178
    Member
    Posted 2 years ago #

    I totally agree with "Gecka" Github is a wonderful thing, and most developers I know use it, and I use it with our projects...

    it only makes since to give credit where credit is due, if you want someone to give you a patch to fix everything the way it should of been without any errors, then i think that person should get some credit..

    Because if Gecka puts in the hard work, and your the only one getting the benefit saying your the only one who has helped with the project, their is no way of anyone knowing who has contributed...

    I have noticed my self allot of bugs with simple facebook connect, and especially not being compatible with allot of plugins.

    and to make it more simple i think the FAQ should be updated
    you currently havethis

    Just before the first input, add this code: [div id="comment-user-details"] [?php do_action('alt_comment_login'); ?]

    (Replace the []'s with normal html greater/less than signs)
    
    i think you should just include the proper code
    <code><div id=&quot;comment-user-details&quot;> <?php do_action('alt_comment_login'); ?></code>

    so people who are not php savvy doesn't have to figure out what a greater and less sign is and so people can just copy and paste the code without having to make any modifications.

    altho i have never posted anything on wordpress so i dont know if its because wordpress doesn't allow it or something.

  10. Samuel Wood (Otto)
    Tech Ninja
    Plugin Author

    Posted 2 years ago #

    Github annoys me. It seems incapable of mirroring my code from SVN repositories (I tried again tonight, it failed... again) and the whole idea behind git strikes me as more than a little bit stupid. But that's me and my opinion.

    As for credit, I always give credit in the changelog when I receive a patch or advice on a code change. This has happened multiple times. Check it yourself.

    Compatibility wise, I'm not concerned with other plugins that do-it-wrong. Feel free to use somebody else's code if you have a problem with that. Doesn't bother me in the slightest. I don't write SFC for other people, I write it because I think it's the best solution and I release it freely because I want to give back to others who can make use of it. Maybe you can't make use of it. I get that. Doesn't bother me. You're free to not use it. It's free-as-in-speech.

    Regarding the code in the FAQ, that's specifically regarding older themes that don't use the comment_form() function. If you have a newer and up-to-date theme using that, then SFC handles it all by itself, without any changes to your theme. Ain't standardization a wonderful thing?

  11. jason102178
    Member
    Posted 2 years ago #

    It is very capable of mirroring code

    http://petersteinberger.com/2010/01/how-to-mirror-an-svn-repository-on-github/

    and that is good your giving others credit were credit is due.

    I am aware that it doesn't bother you if someone chooses not to use your plugin because most plugins are free we can choose which plugins to use..

    Thousands out their to choose from, as i have quit using SFC now for several reasons
    1.Developer doesn't care about users comments,feedback,suggestions, or weather people use it or not...

    2.not willing to make changes to make plugins compatible.

    3. Plugin takes full control over my registration screen by enabling a new re designed registration when i already have a customized registration screen, it totally does away with it..

    Yes I am aware that some older themes do not use the comment_form function, all i asked it that it be updated on the FAQs to have the greater and lessor signs included, if a person is using a newer theme then their would be no reason for them to copy and paste the code so it doesnt effect the people with new themes.

    you cant say your code is 100% perfect either, you may think its not a problem but if others are saying theirs an issue then there must be one.. like Gecka mentioned errors when debugging...

    We never have any kind of errors in our project

    as for thinking its the best solution out their, i really don't think that at this time, it use to be a nice plugin, but has changed dramatically(for the worst)

    the only thing good about it is when you install it it doesnt add like 10 other plugins its one single plugin now...

    I notified the developer of what you had said about errors in his plugins( not expecting much to be done) i am not gonna go back and forth between developers no more trying to get something done.

    so this is me using my Free-as-in-speech.....

    Thanks for the wonderful plugin while it lasted..

    (I almost bet people would say the same thing if you had a poll on weather they liked the new plugin or not) Best of Luck

  12. Samuel Wood (Otto)
    Tech Ninja
    Plugin Author

    Posted 2 years ago #

    The SVN import on github doesn't work for me. I've tried multiple times, it fails every time.

    Best of luck with some other plugin.

Topic Closed

This topic has been closed to new replies.

About this Plugin

About this Topic