WordPress.org

Ready to get started?Download WordPress

Forums

Rollover Themes List
Saving Theme Options (6 posts)

  1. masonjames
    Volunteer Moderator
    Posted 3 years ago #

    Hiya!

    Absolutely love this plugin. Had to remove all mu-plugins for a test install and immediately realized this was one I didn't like living without :D

    One thing I've noticed is that when changing theme options and saving - this plugin redirects me back to the themes.php page rather than the sub-page created by the theme.

    It's a minor annoyance, but I'd love to hear if there's a solution.

    Thanks! :D

    http://wordpress.org/extend/plugins/rollover-themes-list/

  2. David Sader
    Member
    Plugin Author

    Posted 3 years ago #

    Very near the top of the plugin's code (version 3.0.1) you should find
    define( 'DS_THEMES_DISABLE_ORIGINAL_MENU', 'TRUE' );

    That'll cause the ds_unset_themes_submenu function to run which both hides the original Themes menu (so you don't have 2) and add a redirect for any request of the original /themes.php

    So here's what happens under twentyten in my install when I save a custom header.

    When I go to "Appearance->Header" (which if the above is "TRUE" becomes /wp-admin/widgets.php?page=custom-header instead of /wp-admin/themes.php?page=custom-header ) and save the page returns to /wp-admin/widgets.php?page=custom-header.

    What theme do you have causing a bjork? Maybe it needs a tweak in how it adds itself to the appearance menu or how its form action submits.

    Search the offending theme's functions.php for "themes.php" and see what you uncover.

    For example, change something like this

    <form name="custom-colors" id="custom-colors" action="themes.php" method="post">

    to this
    <form name="custom-colors" id="custom-colors" action="" method="post">

  3. David Sader
    Member
    Plugin Author

    Posted 3 years ago #

    I've just updated this plugin to 3.0.1.2, minor tweaks. Just to make sure that what is in the repository is identical to what I have installed.

  4. masonjames
    Volunteer Moderator
    Posted 3 years ago #

    Rock on sir. Rock on.

    I've grabbed up the new version and installed.

    This particular theme comes from WPMU DEV and has the following entries in the option-functions.php file:
    header("Location: themes.php?page=functions.php&saved=true");
    and
    header("Location: themes.php?page=functions.php&reset=true");

    So my question now is: Is there anything wrong with doing things this way AND can I just change the references from themes.php to widgets.php everywhere in the files and be alright?

    Also, this is a BuddyPress-enabled theme though I don't know if that makes a difference either.

    Thanks again! :D

  5. David Sader
    Member
    Plugin Author

    Posted 3 years ago #

    just change the references from themes.php to widgets.php everywhere in the files

    Should work. But editing a theme's files makes it a pain to go backwards, update theme, or remove plugin though.

  6. masonjames
    Volunteer Moderator
    Posted 3 years ago #

    Cool. Will test out. Probably not worth changing as Theme Options are not something that have to be changed all that often once things are set up the way you wan them.

    Appreciate all the feedback. Thanks again and again!

Topic Closed

This topic has been closed to new replies.

About this Plugin

About this Topic