WordPress.org

Ready to get started?Download WordPress

Forums

Revision Control
No way to delete revisions (12 posts)

  1. system11
    Member
    Posted 3 years ago #

    Seems to be no way to delete revisions - I can click on the compare/delete which changes checkboxes by revisions to tickboxes instead of radio buttons, but the only clickable button underneath is 'compare' which complains that I haven't selected two revisions.

  2. mbrsolution
    Member
    Posted 3 years ago #

    I have no issues with it. I can delete revisions from my posts. I just select and configure Revision Control: Currently storing a maximum of 5 Revisions to default revision settings. This works for me and I am running wordpress 3.0.1. Also make sure that when you select the option above you click on the update button of the post. Let me know if this helps.

  3. Bryn
    Member
    Posted 3 years ago #

    Hi
    I have been running into this issue whereby the Delete / Compare buttons no longer swap. Its happening in Firefox and IE on a number of sites. I believe it started after moving to WP 3.0.1, but cannot confirm.

    Workaround:
    In \wp-content\plugins\revision-control\revision-control.php, around line 615,

    <input type="button" class="button-secondary toggle-type"
     value="<?php esc_attr_e('Delete', 'revision-control') ?>"
    id="revisions-delete" style='display:none' />

    remove
    style='display:none'
    to give you

    <input type="button" class="button-secondary toggle-type"
    value="<?php esc_attr_e('Delete', 'revision-control') ?>"
    id="revisions-delete" />

    That will show the Delete / Compare buttons all the time, but it will get you by for now.

    And many thanks to dd32, the Author for such a great plugin.

  4. system11
    Member
    Posted 3 years ago #

    That sounds like the exact same problem I've seen.

  5. mbrsolution
    Member
    Posted 3 years ago #

    I have tried to follow your issue above Bryn and yes you are correct it does not compare between revisions. I guess it is a bug in the code.

    What I have been doing is keeping only 5 revision plus the current one used, which equals to 6 all up. I select
    Revision Control: Currently storing a maximum of 5 Revisions and then I just click on update. This works for me without having to look at the php code. And yes I know that I am not comparing between revision. In reality you would not keep many revisions because your wordpress would become huge and bloated after a while.

    I hope this helps you in any way.

  6. mauriziokg
    Member
    Posted 3 years ago #

    Instead of applying the work-around by Bryn, try inserting
    ====
    $('.button-secondary').toggle();
    ====
    as line 6 of revision-control.js (i.e. just below the other "toggle()" line. For me this works with WP 3.0.1.

  7. mbrsolution
    Member
    Posted 3 years ago #

    Hello mauriziokg, I have applied your suggestion and it works very well with WP 3.0.1.
    Thank you so much for your contribution.
    Well done

  8. Zoinks! Graphics
    Member
    Posted 3 years ago #

    Another instance of the plugin not working "out of the box" on WP 3.0.1. Thanks, mauriziokg for the suggestion above that makes it work!

  9. rayfusci
    Member
    Posted 3 years ago #

    The problem is in version 2.0.1, but not in version 2.0. New installs of the plugin give you 2.0.1 even though it's labeled as 2.0 in the repository, which is causing some confusion about what people have installed. Check the version in your plugin directory to know which one you have installed.

    The fix for 2.0.1 is to back out one of the changes made to 2.0. On line 613:
    2.0: <td colspan="4" style="text-align:left" class="check-column">

    2.0.1: <td colspan="4">

    Change that line back to the way it was in 2.0, and the delete button will come back.

  10. tff
    Member
    Posted 3 years ago #

    Here is a patch for 2.0 (2.0.1)
    Obviously is the same what rayfusci said but more distinctive and proper. PS Don't look at the dates of files.

    Revision Control WordPress Plug-in
    Ver. 2.0 (or 2.0.1 according to comments in revision-control.php)
    
    --- revision-control.js	Thu Jan 15 12:14:12 1970
    +++ revision-control.js	Thu Jan 15 12:14:12 1970
    @@ -3,6 +3,7 @@
     	$('a#revision-compare-delete-label').bind('click',
     	function () {
     		$(this).parents('table').find('.check-column input.toggle-type').toggle();
    +		$(this).parents('table').find('.compare-delete-submit-cell input.toggle-type').toggle();
     	});
    
     	$('#revisions-delete').bind('click',
    --- revision-control.php	Thu Jan 15 12:14:12 1970
    +++ revision-control.php	Thu Jan 15 12:14:12 1970
    @@ -610,7 +610,7 @@
     	</tbody>
     	<tfoot>
     		<tr>
    -			<td colspan="4">
    +			<td colspan="4" class="compare-delete-submit-cell">
     				<span class="hide-if-no-js">
     				<input type="button" class="button-secondary toggle-type" value="<?php esc_attr_e('Delete', 'revision-control') ?>" id="revisions-delete" style='display:none' />
     				<input type="button" class="button-secondary toggle-type" value="<?php esc_attr_e('Compare', 'revision-control') ?>" id="revisions-compare" />
  11. fromtheranks
    Member
    Posted 3 years ago #

    tff,

    Thank you for this fix. It works very nicely. The only "gotcha" was that after it was fixed realizing I had to click on the "Compare Delete" hyperlink to toggle back and forth between Compare and Delete. As this wasn't working initially, I ignored the hyperlink.

    Thanks also to dd32 for a great plugin, which plays nicely with WP3.1.1 once the fix is in place.

  12. GillesGagnon
    Member
    Posted 3 years ago #

    Thanks rayfusci!

    your post (and others') saved the day. I was about to trash this plugin.

    I wonder why this big flaw was not caught by the author? great plugin now that it works properly

    cheers,

    G.

Topic Closed

This topic has been closed to new replies.

About this Plugin

About this Topic