WordPress.org

Ready to get started?Download WordPress

Forums

Query Wrangler
[resolved] Feature Requests? (9 posts)

  1. mpvanwinkle77
    Member
    Posted 2 years ago #

    Hey guys, I was just about to start working on a "Views for WordPress" plugin when I found your plugin. Great job! I have a couple feature requests and I would be willing to contribute code for them if you are interested. Should I post the requests on Trac or do you guys have a project site elsewhere? GitHub?

    Feature Requests:
    1) Expose filters. This is something drupal offers allowing front-end views to toggle filters.
    2) Page Numbers. Just an alternative pager offering page numbers instead.
    3) Down the road think about adding a place under the field settings where the admin can add styles to a particular field output.

    But, overall, awesome work!

    http://wordpress.org/extend/plugins/query-wrangler/

  2. Jonathan Daggerhart
    Member
    Plugin Author

    Posted 2 years ago #

    Hey mpvanwinkle77,

    Thanks for the encouragement and feature requests.

    We do have the dev version on github.
    https://github.com/daggerhart/Query-Wrangler
    I'm a bit new to git, so everything is in the master repo.

    The version for download (if you want to call it stable) is just in WP svn, and I have a local copy. I'm trying to get 1.3 out soon so I can implement a legitimate workflow for stable vs dev.

    Feature Request comments:

    1) Great idea!
    2) I ended up having to write my own pager, because of the WP_Query class forgetting what page a user is on, and how many items are found. My plan was to either write my own page-numbered version, or attempt to allow WP PageNavi plugin to work, since its so popular. I'm down with any solution.
    3) Another great suggestion. This shouldn't be too hard at all.

    We would appreciate any suggestions or code you have to offer. This project could likely get big fast.

    Thanks again,
    Jonathan

  3. mpvanwinkle77
    Member
    Posted 2 years ago #

    Thanks Jonathan, I just put together some code for the page numbers and sent you guys a pull request on Github. Let me know if there's a better way to contribute. I'll try to send you more code soon.

    Mike

  4. Jonathan Daggerhart
    Member
    Plugin Author

    Posted 2 years ago #

    That's awesome, thanks.

    But now I have a conflict. I worked on this same thing and a few other things this morning including the css classes, then committed the changes. Now I don't know how to revert to a previous commit in order to implement your changes.

    Any chance you could point me in the right direction to getting your commits into the master? I have tried a few git commands I've found, but ultimately they didn't do what I was expecting.

    Sorry to be a git-newb, but I would rather implement your solutions to the pager than my own.

    I'll keep working on it.

    Thanks again!

  5. mpvanwinkle77
    Member
    Posted 2 years ago #

    Well, I'm a bit of a github newb as well, but I think there's a "cherry-pick" approach

    http://technosophos.com/content/git-cherry-picking-move-small-code-patches-across-branches

    But I'm not sure this will work on a forked branch.

    You should aslo be able to do

    git reset --hard COMMITNUMBER (http://stackoverflow.com/questions/4114095/git-revert-to-previous-commit-how)

    But that's going to undo any changes you've made. Let me know if you figure it out. I can always re-clone the master and re-submit the pull request. But I guess we should figure out the work flow since this is a project likely to attract even more contributors.

  6. Jonathan Daggerhart
    Member
    Plugin Author

    Posted 2 years ago #

    Ok, I just did it the dumb way. I downloaded your fork and re added my small changes by hand.

    I agree that with more contributors we need a solid strategy for workflow. I'll try to work out a plan tonight.

    Also, I hope you don't mind, but I made a few changes to your code, mainly formatting. I'm a big fan of very verbose code, especially for a project like this that can get large quickly and have multiple contributors. So when you see the changes, please take no offense. I mainly just moved things around and added line breaks. Another small thing I did was change your tabs to spaces, to keep the formatting the same throughout all the files.

    Additionally, I moved your pager_types hook into the data.hooks.inc file, just as a way to keep with the current organization.

    I really don't want this plugin to become a hodge podge of different coding styles and editor formattings like I see in a lot of other WP work, so I'm going to also write up some simple guidelines for contributing.

    I don't claim to know the best way to organize this project, so I'm totally open to any recommendations you have if there are some changes you would like to see.

    I put up a forum for query wrangler a few days ago, and it's still completely empty, but I'm going to add a developers forum to it and write up some sort of contributing plan and guidelines.

    Again, I know how these things can come across in text, but I mean no disrespect or offense with any of my changes or suggestions. I completely appreciate all the help I can get, I just want to keep the code easy to read and with some semblance of a formatting standard.

    Here is the link to the query wrangeler's forum where I will be putting some documentation, guidelines and strategy.

    http://www.widgetwrangler.com/forum

    Does this all sound reasonable to you?

  7. mpvanwinkle77
    Member
    Posted 2 years ago #

    Absolutely, and no offense taken, as I get more familiar with the code I'm sure I'll get a feeling for the organization.

    And yes, organization is important so I'd rather adapt to your organization structure to start and then suggest changes only when something isn't working.

    Ego free coding is the best route to a successful project.

    I'll move this discussion to the forum above.

    Cheers

  8. thecorkboard
    Member
    Posted 2 years ago #

    Kind of a feature request:

    Could you create a view for multisite that queries the entire site for a custom post type based on a custom taxonomy?

  9. Jonathan Daggerhart
    Member
    Plugin Author

    Posted 1 year ago #

    Exposed filters are in 1.6beta1, you can get it here:
    http://wordpress.org/extend/plugins/query-wrangler/developers/

Topic Closed

This topic has been closed to new replies.

About this Plugin

About this Topic