WordPress.org

1. Clifford P
   Member
   Posted 6 months ago #

   Here are the scripts from the VIEW SOURCE of my wp-admin login page:
   

   <script type='text/javascript' src='wp-includes/js/...'></script>
   <script type='text/javascript' src='wp-includes/js/jquery/...'></script>
   <script type='text/javascript' src='http://....com/wp-content/plugins/qr-code-tag/js/jquery.tooltip.min.js?ver=3.2.1'></script>
   <script type='text/javascript' src='http://....com/wp-content/plugins/qr-code-tag/js/qrct.js?ver=3.2.1'></script>
   
   <script type='text/javascript' src='wp-content/plugins/.../assets/global.js?ver=1.1'></script>

   So, you see that all the other src='' are relative, and the QR Code's src='' is not, since it starts with http://domain.com/... instead of //domain.com/... or wp-content/plugins/...

   Please fix. Thank you.

   http://wordpress.org/extend/plugins/qr-code-tag/

2. Clifford P
   Member
   Posted 6 months ago #

   The enqueue's are located in this file:
   \wp-content\plugins\qr-code-tag\lib\qrct\QrctWp.php
   -starting at Line 97

   Here's the code:
   

   // include javascript and css styles
           wp_enqueue_script('jquery');
           wp_enqueue_script('jquery-tooltip', $this->pluginUrl.'js/jquery.tooltip.min.js','jquery');
           wp_enqueue_script('qrcodetagging', $this->pluginUrl.'js/qrct.js','jquery-tooltip');
           wp_enqueue_style('qrcodetagging', $this->pluginUrl.'css/qrct.css');

   Changing to this fixes the problem:
   

   // include javascript and css styles
           wp_enqueue_script('jquery');
           wp_enqueue_script('jquery-tooltip', plugins_url('/qr-code-tag/js/jquery.tooltip.min.js'),'jquery');
           wp_enqueue_script('qrcodetagging', plugins_url('/qr-code-tag/js/qrct.js'),'jquery-tooltip');
           wp_enqueue_style('qrcodetagging', plugins_url('/qr-code-tag/css/qrct.css'),'jquery-tooltip');

   Thanks for this plugin. Please implement in next release.

3. Clifford P
   Member
   Posted 6 months ago #

   FYI: There might be better ways to implement within a plugin, but that's a fix for now.

   Please also implement not loading the script unless needed - maybe checkout Jedi Knight way at http://scribu.net/wordpress/optimal-script-loading.html

   And/Or http://codex.wordpress.org/Function_Reference/wp_enqueue_script#Load_scripts_only_on_plugin_pages

   Or any method.

Reply

You must log in to post.