WordPress.org

Ready to get started?Download WordPress

Forums

PTM AJAX Comments
Feature requests (14 posts)

  1. Peter Michael
    Member
    Posted 3 years ago #

    If you have any feature requests please post them in this thread, thanks.

    http://wordpress.org/extend/plugins/ptm-ajax-comments/

  2. maxemil
    Member
    Posted 3 years ago #

    great plugin :)

    I have a small request / issue..
    In WP 3x you can define your fields in comment_form($args);
    http://codex.wordpress.org/Function_Reference/comment_form

    I tried the plugin on a page where I removed the 'url' in $fields.
    This returns a script error for the plugin IN IE6 at the validation for the required fields / empty data.

    I predict developers will be using the WP 3x comment functionality alot to extend the name/email/url/comment normalities...

    Is there a way you can extend your plugin to validate data only on fields filtered by the 'comment_form_default_fields' ?!?

    Best regards \Emil

  3. Peter Michael
    Member
    Posted 3 years ago #

    Hi Emil

    The plugin itself does 1 validation: it checks if the comment field is not empty prior submitting the form. This is done via jQuery, see 'js/ptm-ajax-comments.dev.js' lines 78 - 83.

    All other validations are done by WordPress, the plugin just returns the built-in messages, see 'lib/Class.PTM_AJAXCommentsFront.php'. URL is never required anyway, there is no validation for that field.

    What is the exact error you are getting?

    Then again, IE6? C'mon, it's 2011. :)

  4. maxemil
    Member
    Posted 3 years ago #

    The error only occurs when email, name or url is not entered (wp set to email and name is required).
    The error does not occur when only Comment is empty. (the "you need to enter a comment" is displayed correctly).

    The error is:
    '1.WholeText' is null or not an object

    As I saw (at line 115) 'WholeText' inside your ptm-ajax-comments.dev.js file I assumed it was a check on your part.

    IE6 is for people like me, who has to conform to ancient big companies :)

  5. maxemil
    Member
    Posted 3 years ago #

    When disabeling "Comment author must fill out name and e-mail", and submitting a comment with only email and comment-text (empty name), the plugin does not break in IE6

  6. maxemil
    Member
    Posted 3 years ago #

    when changing line 115 to
    _error = "Name and Email must be entered!";
    it works.

  7. Peter Michael
    Member
    Posted 3 years ago #

    Hi Emil,

    thanks for diggin' into this. :)

    Can you have a look what the XMLHttpRequest.responseText is? (insert alert(XMLHttpRequest.responseText); at line 114 for ex.)

    If ''1.WholeText' is null or not an object' then WP is returning not a standard error (like wp_die()). I'm extracting the first paragraph on line 114, so, that one is missing thus getting NULL.

  8. maxemil
    Member
    Posted 3 years ago #

    Btw, Im using IETester and in a ie6 session with debugbar and companion.js

    The alertbox (same as displayed when running it via firefox/firebug), so I guess its how IE interprents the return message thats the issue.. dunno.

    ---------------------------
    Microsoft Internet Explorer
    ---------------------------
    <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
    <!-- Ticket #11289, IE bug fix: always pad the error page with enough characters such that it is greater than 512 bytes, even after gzip compression abcdefghijklmnopqrstuvwxyz1234567890aabbccddeeffgghhiijjkkllmmnnooppqqrrssttuuvvwwxxyyzz11223344556677889900abacbcbdcdcededfefegfgfhghgihihjijikjkjlklkmlmlnmnmononpopoqpqprqrqsrsrtstsubcbcdcdedefefgfabcadefbghicjkldmnoepqrfstugvwxhyz1i234j567k890laabmbccnddeoeffpgghqhiirjjksklltmmnunoovppqwqrrxsstytuuzvvw0wxx1yyz2z113223434455666777889890091abc2def3ghi4jkl5mno6pqr7stu8vwx9yz11aab2bcc3dd4ee5ff6gg7hh8ii9j0jk1kl2lmm3nnoo4p5pq6qrr7ss8tt9uuvv0wwx1x2yyzz13aba4cbcb5dcdc6dedfef8egf9gfh0ghg1ihi2hji3jik4jkj5lkl6kml7mln8mnm9ono -->
    <html xmlns="http://www.w3.org/1999/xhtml" dir="ltr" lang="en-US">
    <head>
    	<meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
    	<title>WordPress › Error</title>
    	<link rel="stylesheet" href="http://localhostPathToMyWPInstall/wp-admin/css/install.css" type="text/css" />
    </head>
    <body id="error-page">
    	<p>Error: please fill the required fields (name, email).</p></body>
    </html>
    
    ---------------------------
    OK
    ---------------------------

    Reading up on http://www.javascriptkit.com/jsref/ajax.shtml it would seem that if WP is relying on XMLHttpRequest and hasent made a ActiveXObject parser this is the culprint.

    A maby solution, however this is out of scope for a plugin imho :)
    http://www.sencha.com/forum/showthread.php?45402-IFrame-fallback-for-Ajax-Requests
    or http://www.cristiandarie.ro/asp-ajax/Async.html

  9. Peter Michael
    Member
    Posted 3 years ago #

    Hey Emil,

    I guess its how IE interprents the return message thats the issue

    Same guess here as the response actually looks good.

    However, I think I'm not going to fiddle around to support IE6 :)

    Thanks again for digging into this!

  10. delgado2009
    Member
    Posted 3 years ago #

    Hi Pete, I have a question, if someone posts a comment, do not automatically appear in the list? I mean you have to refresh the page to appear?

  11. Peter Michael
    Member
    Posted 3 years ago #

    @delgado2009

    No. It probably means that you didn't add the callback function name in the plugin settings. Any URL?

  12. delgado2009
    Member
    Posted 3 years ago #

    I added the callback function name in the plugin settings.
    The problem is that when I write a comment and I add it, it appears that the comment was added, but I can see it only after giving refresh the page.

  13. delgado2009
    Member
    Posted 3 years ago #

    Solved the problem,I forgot to add <h3 id="respond">

  14. Peter Michael
    Member
    Posted 3 years ago #

    Nice, glad you solved it.

Topic Closed

This topic has been closed to new replies.

About this Plugin

About this Topic