WordPress.org

Ready to get started?Download WordPress

Forums

Polldaddy Polls & Ratings
[resolved] Extraneous br tag inserted before comment_text in ratings.ph (5 posts)

  1. JeanPaulH
    Member
    Posted 1 year ago #

    In polldaddy/ratings.php at line 24 an extra <br /> is inserted even if ratings for comments are disabled. I believe the condition for $rating_pos == 0 is wrong, but imho this filter (line 158) shouldn't trigger anyway when ratings are disabled.

    http://wordpress.org/extend/plugins/polldaddy/

  2. Eoin Gallagher
    Member
    Plugin Author

    Posted 1 year ago #

    Thanks djr, I have updated 2.0.15 to not include br tag if comments are disabled.

    I'm not sure about changing when to trigger the filter as if I include a lookup on comments option, it will be called on each page load whether there is comment text or not.

  3. JeanPaulH
    Member
    Posted 1 year ago #

    I hope we're talking about the same bug :-) I meant an extra <br /> is inserted in comment text, even though we disabled ratings for comments. You are saying "if comments are disabled", but that's not what I meant. We do have comments (so no comments disabled), we just don't have comment ratings and therefore the plugin shouldn't insert the extra <br />

    Thanks!

  4. Eoin Gallagher
    Member
    Plugin Author

    Posted 1 year ago #

    Thanks djr, I believe we are talking about the same bug and a fix should be now included with 2.0.15. If you still see the br tag, remove the plugin, download it again and reinstall.

  5. JeanPaulH
    Member
    Posted 1 year ago #

    Yes, you were right. Fixed in 2.0.15. Marked as Resolved.

Topic Closed

This topic has been closed to new replies.

About this Plugin

About this Topic