WordPress.org

Ready to get started?Download WordPress

Forums

Plugin Premium Package Manager for WP Networks
Fatal error when eShop installed but not ac (7 posts)

  1. RavanH
    Member
    Posted 3 years ago #

    Hi,

    Activating the Premium Packages plugin without eShop installed, results in a message that eShop is not installed. But when eShop is installed but not activated on the main site, the Premium page just remains empty. In the logs, I see:
    PHP Fatal error: Call to undefined function eshop_cart_process() in /xxx/xxx/xxx/wp-content/plugins/plugin-premium-package-manager-for-wp-networks/lib/class.post-type.php on line 257

    Activating eShop on the main site fixes it of course, so there is no real problem. Just that it would make it more user-friendly if there was a message in this case too :)

    Another suggestion: it would be nicer if the message on individual sites Check out our Upgrades for more features and enhancements. and the My Account page could be hidden until there are actual Premium Packages configured on the main site...

    Anyway, thanks for this great plugin!

    http://wordpress.org/extend/plugins/plugin-premium-package-manager-for-wp-networks/

  2. Ron Rennick
    MultiSite Guru
    Plugin Author

    Posted 3 years ago #

    Thanks for the feedback :) My general thought is that I included this note on the plugin page:

    This plugin is in beta ...

    People using it should expect to encounter unfinished features, gotchas, etc.

    Responses in order

    1) In the future I hope to make it so the premium package manager does not require eShop to be active on the main site to function correctly. Since the current state causes no harm on the front end of any of the sites, I'm not expecting to add interim measures to make it polished.

    2) admin message - making the dashboard notice customizable is on the to do list. The next release (currently being tested) does not have this, but the admin message will probably make it into the release after that.

    3) checking to see if there are premium packages would require a DB query for every admin page load. An important goal (for me) of this plugin is to keep it lightweight. What I'm more inclined to do is put a customizable message on that screen.

  3. RavanH
    Member
    Posted 3 years ago #

    People using it should expect to encounter unfinished features, gotchas, etc.

    Sure, I got that... Was just making some suggestions :)

    3) checking to see if there are premium packages would require a DB query for every admin page load. An important goal (for me) of this plugin is to keep it lightweight. What I'm more inclined to do is put a customizable message on that screen.

    Or maybe even make the message optional? Or empty so that nothing is shown by default? That would boil down to the same thing I suggested... Then the Super Admin would have time to configure some packages and when done, add a custom Site Admin Message :)

    Another question: Are you planning to add a text_domain for translations? I am hoping to use this on a French network some day...

  4. Ron Rennick
    MultiSite Guru
    Plugin Author

    Posted 3 years ago #

    Or maybe even make the message optional?

    Good suggestion. When I make it customizable, I'll add a checkbox.

    Are you planning to add a text_domain for translations?

    Actually, that's already there. I haven't added the .pot file yet. I'll update this thread when I add that to the dev version.

  5. RavanH
    Member
    Posted 3 years ago #

    Are you planning to add a text_domain for translations?

    Actually, that's already there. I haven't added the .pot file yet. I'll update this thread when I add that to the dev version.

    I see code like __('Hide this plugin on the site plugin screens') and __( 'Manage Menus', '' ) but both would make WP look for a translation in the main .mo database, or am I mistaken?

  6. Ron Rennick
    MultiSite Guru
    Plugin Author

    Posted 3 years ago #

    I just added a .pot file and the code to register the text domain to the dev version.

    If you are interested in doing so, you can make me a list of all the strings that don't have the text domain and I'll add them within a day or so of getting the list.

  7. RavanH
    Member
    Posted 3 years ago #

    excellent! :)

Topic Closed

This topic has been closed to new replies.

About this Plugin

About this Topic