WordPress.org

Ready to get started?Download WordPress

Forums

Password Protected
[resolved] Can Break Theme Customizer (5 posts)

  1. Jason Lemahieu (MadtownLems)
    Member
    Posted 1 year ago #

    When Password Protected is enabled, the Theme Customizer fails to let you preview your changes unless you have also already authenticated against your new password.

    While this isn't necessarily a huge deal, it actually raises the question of if the plugin should even require Site Administrators (and Network Administrators) to enter the site password in order to view it.

    My suggestion would be to allow Site Admins and Network Admins to be able to view the site regardless, but display a reminder that the site is locked to most people. For example, this is a screenshot of what a network/site admin sees when viewing one of our sites when a Site Offline message plugin we wrote is in use: http://i.imgur.com/eyOjM.png

    I do know that you wanted to keep your plugin relatively lightweight, so I could easily see why you wouldn't want this whole message/reminder stuff, but I do think the behavior of requiring Site Admins and Network Admins to log in is kind of awkward (especially when they can't find the password in the dashboard or even database), and the breaking of Theme Customizations is just a side effect of that.

    Note that while the Theme Customizer isn't too heavily used right now, I think it will be picking up steam as more developers move away from Settings pages to using the Customizer screen instead.

    As always, thanks for your input and continued support :)

    http://wordpress.org/extend/plugins/password-protected/

  2. Ben Huson
    Member
    Plugin Author

    Posted 1 year ago #

    I am keen to keep the plugin lightweight but that does seem sensible.
    I'll have a think about wether this is the best default behaviour or wether it would be best implemented via a filter or something.

  3. Jason Lemahieu (MadtownLems)
    Member
    Posted 1 year ago #

    Have you thought about keeping Password Protected super lightweight, but also have a Password Protected Expansion Pack or something, that adds a customizable message and some other random but useful stuff?

  4. Ben Huson
    Member
    Plugin Author

    Posted 1 year ago #

    I think I may add the ability for admins to view the site by default in a future version.
    I've added an issue for it here:
    https://github.com/benhuson/password-protected/issues/17

    Personally I do not have the time to build an Expansion Pack but anyone could build an add-on plugin if they need to extend the functionality. I am happy to add extra hooks/filters if needed.

    Ben

  5. Ben Huson
    Member
    Plugin Author

    Posted 1 year ago #

    Version 1.4 (just released) includes a checkbox to allow admins to access site without password which also works round the Theme Customizer issue.

Topic Closed

This topic has been closed to new replies.

About this Plugin

About this Topic

Tags

No tags yet.