WordPress.org

Ready to get started?Download WordPress

Forums

Ninja Forms
[resolved] Translation errors in v1.2.9 (7 posts)

  1. daveshine (David Decker)
    Member
    Plugin Contributor

    Posted 2 years ago #

    Hi there!
    I was excited that you finally added internationalization with v1.2.9 - and that is really important! So, a big "Thank you!" :-)

    However, there are some errors/typos in the latest version which I found out with testing:

    In file "ninja_forms.php" you have:
    load_plugin_textdomain( 'ninja-forms', false, $plugin_dir );

    it should go this way, otherwise translations will not load:
    load_plugin_textdomain( 'ninja-forms', false, $lang_dir );

    Then in both files "includes/body_settings.php" and "includes/body_subs.php" you have typo errors - you used this (9 times each file!):
    e_(...)

    but it should be this way:
    _e(...)

    --> This error leads to fatal errors on the forms and settings page!

    Otherwise you have a lot of gettext strings without textdomain - you should always only use "ninja-forms" as this is the one you've defined and are loading!

    __( 'Your string', 'ninja-forms' );
    _e( 'Your string', 'ninja-forms' );

    Also please use single quotes for all in all gettext strings - it's the recommended way!

    Thank you very much!
    -Dave from Germany

    P.S. Currently translating your plugin into German :)

    http://wordpress.org/extend/plugins/ninja-forms/

  2. James Laws
    The WP Ninjas
    Plugin Author

    Posted 2 years ago #

    Thanks for the updates. When you fat finger and then copy and paste a lot it causes all kinds of chaos. Working on fixing them all as I type this. Which will hopefully not cause additional errors. :)

  3. James Laws
    The WP Ninjas
    Plugin Author

    Posted 2 years ago #

    I actually caught the lang_dir error but totally missed the others. Sigh. Coding in the wee hours...we should stop that. :)

  4. daveshine (David Decker)
    Member
    Plugin Contributor

    Posted 2 years ago #

    Thanx! No problem, James - I know these things myself happening way too often sometimes...

    Thanx for your hard work, Dave :)

  5. James Laws
    The WP Ninjas
    Plugin Author

    Posted 2 years ago #

    David,

    All should be corrected in version 1.2.9.1.

    Thanks again for the heads up and for translating it.

  6. Kevin Stover
    The WP Ninjas
    Plugin Author

    Posted 2 years ago #

    Hey David,

    Thanks for the information and the help with translation. If you're ok with it, we'd love to include your translation in the ninja-forms package. When you get finished, let me know via email: kevin [a t] wpninjas.net.

    Thanks,

    Kevin

  7. daveshine (David Decker)
    Member
    Plugin Contributor

    Posted 2 years ago #

    Hi James & Kevin!

    Thanx for your superfast update - all ok now, great! :-)

    Of course I'll send you my language files, I guess I could finish this weekend :-)

    -Dave.

Topic Closed

This topic has been closed to new replies.

About this Plugin

About this Topic